Set up verification of executables on build #627

Author: alansemenov

.github/workflows/build.yml

@@ -0,0 +1,76 @@
+name: Build
+
+on:
+  push:
+
+jobs:
+
+  build:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v5
+        with:
+          fetch-depth: 0
+
+      - name: Set up Go
+        uses: actions/setup-go@v6
+        with:
+          go-version: 1.24.0
+
+      - name: Test
+        run: go test -v ./...
+
+      - name: GoReleaser Action
+        uses: goreleaser/goreleaser-action@v6
+        with:
+          args: --clean --snapshot --skip=snapcraft
+
+      - name: Upload the binaries
+        uses: actions/upload-artifact@v4
+        with:
+          name: Enonic CLI binaries
+          path: dist/enonic_*/
+
+      - name: Upload package.json and index.js
+        uses: actions/upload-artifact@v4
+        with:
+          name: Node files
+          path: |
+            package.json
+            index.js
+
+  verify:
+    needs: build
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ubuntu-latest, macos-latest, windows-latest]
+        arch: [x64, arm64]
+
+    steps:
+      - name: Download Enonic CLI binaries
+        uses: actions/download-artifact@v4
+        with:
+          name: Enonic CLI binaries
+          path: dist/
+
+      - name: Download Node files
+        uses: actions/download-artifact@v4
+        with:
+          name: Node files
+          path: ./
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v6
+        with:
+          node-version: 22
+
+      - name: Make the binaries executable
+        run: chmod +x dist/enonic_*/enonic
+
+      - name: Run node index.js
+        run: node index.js
+        env:
+          NODE_ARCH: ${{ matrix.arch }}

.github/workflows/go.yml

@@ -40,8 +40,7 @@ jobs:
 
       - uses: actions/setup-node@v6
         with:
-          node-version: '20.x'
-          registry-url: 'https://registry.npmjs.org'
+          node-version: 22
 
       - run: npm publish
         env:

.github/workflows/release.yml

@@ -46,17 +46,13 @@ builds:
       - arm64
       - arm
 
-    goarm:
-      - 6
-    # - 7
-
     # windows_arm64 builds fail: exit status 2: # golang.org/x/sys/windows
     #../../../.go/pkg/mod/golang.org/x/[email protected]/windows/zsyscall_windows.go:2833:38: undefined: WSAData
     #../../../.go/pkg/mod/golang.org/x/[email protected]/windows/zsyscall_windows.go:3106:51: undefined: Servent
     #../../../.go/pkg/mod/golang.org/x/[email protected]/windows/zsyscall_windows.go:3120:50: undefined: Servent
     ignore:
       - goos: windows
-        goarch: arm64
+        goarch: arm
 
     hooks:
       post: ./script.sh
@@ -160,7 +156,7 @@ scoops:
 #  - "data"
 #  - "config.toml"
 
-brews:
+homebrew_casks:
 
   - skip_upload: false
 
@@ -172,8 +168,9 @@ brews:
 
     # Template for the url.
     # Default is "https://github.com/<repo_owner>/<repo_name>/releases/download/{{ .Tag }}/{{ .ArtifactName }}"
-    url_template: https://repo.enonic.com/public/com/enonic/cli/{{ .ProjectName }}/{{ .Version }}/{{ .ArtifactName }}
-
+    url:
+      template: "https://repo.enonic.com/public/com/enonic/cli/{{ .ProjectName }}/{{ .Version }}/{{ .ArtifactName }}"
+      verified: "https://repo.enonic.com"
     # Allows you to set a custom download strategy.
     # Default is empty.
     #  download_strategy: GitHubPrivateRepositoryReleaseDownloadStrategy
@@ -184,10 +181,6 @@ brews:
       name: goreleaserbot
       email: [email protected]
 
-    # Folder inside the repository to put the formula.
-    # Default is the root folder.
-    directory: Formula
-
     # Your app's homepage.
     # Default is empty.
     homepage: https://enonic.com/

.goreleaser.yml

@@ -4,6 +4,7 @@
 
 const path = require('path');
 const fs = require('fs');
+const { arch, platform, argv, env } = require('node:process');
 
 // Mapping from Node's `process.arch` to Golang's `$GOARCH`
 const ARCH_MAPPING = {
@@ -32,32 +33,53 @@ const validateConfiguration = (packageJson) => {
 const parsePackageJson = () => {
     const packageJsonPath = path.resolve(__dirname, 'package.json');
     if (!fs.existsSync(packageJsonPath)) {
-        throw new Error('Unable to find package.json. Please run this script at root of the package you want to be installed');
+        console.error('Unable to find package.json. Please run this script at root of the package you want to be installed');
+        process.exit(1);
     }
 
     const packageJson = JSON.parse(fs.readFileSync(packageJsonPath));
     const error = validateConfiguration(packageJson);
     if (error && error.length > 0) {
-        throw new Error(`Invalid package.json: ${error}`);
+        console.error(`Invalid package.json: ${error}`);
+        process.exit(1);
     }
 
-    if (!(process.platform in PLATFORM_MAPPING)) {
-        throw new Error(`Installation is not supported for platform "${process.platform}"`);
+    if (!(platform in PLATFORM_MAPPING)) {
+        console.error(`Installation is not supported for platform "${platform}"`);
+        process.exit(1);
     }
 
-    if (!(process.arch in ARCH_MAPPING)) {
-        throw new Error(`Installation is not supported for architecture "${process.arch}"`);
+    /*
+        This part is used for cross-platform verification of binaries during CI/CD.
+    */
+    let thisArch = arch;
+    if (env['NODE_ARCH']) {
+        if (platform === 'win32' && env['NODE_ARCH'] === 'arm64') {
+            console.log(`Skipping verification for ${platform} ${arch}`);
+            process.exit(0);
+        }
+        if (platform === 'linux' && env['NODE_ARCH'] === 'arm64') {
+            thisArch = 'arm';
+        } else {
+            thisArch = env['NODE_ARCH'];
+        }
+    }
+    /**/
+
+    if (!(thisArch in ARCH_MAPPING)) {
+        console.error(`Installation is not supported for architecture "${thisArch}"`);
+        process.exit(1);
     }
 
     const project = packageJson.goBinary;
     let binName = project;
 
     // Binary name on Windows has .exe suffix
-    if (process.platform === 'win32') {
+    if (platform === 'win32') {
         binName += '.exe';
     }
 
-    const binFolder = `${project}_${PLATFORM_MAPPING[process.platform]}_${ARCH_MAPPING[process.arch]}`;
+    const binFolder = `${project}_${PLATFORM_MAPPING[platform]}_${ARCH_MAPPING[thisArch]}`;
     const binPath = path.resolve(__dirname, 'dist', binFolder, binName);
 
     return {
@@ -66,15 +88,21 @@ const parsePackageJson = () => {
     };
 }
 
-const argv = process.argv;
 if (argv) {
     try {
         const opts = parsePackageJson();
         if (!opts) {
             console.error('Invalid package.json');
-            return;
+            process.exit(1);
         }
 
+        if (!fs.existsSync(opts.binPath)) {
+            console.error(`Binary not found at ${opts.binPath}`);
+            process.exit(1);
+        }
+
+        console.log(`Executing binary: ${opts.binPath}`);
+
         const {spawn} = require('child_process');
         spawn(opts.binPath, argv.slice(2), { stdio: 'inherit' });
     }