Skip to content

Returned nodes should be dereferenced #1

@ComLock

Description

@ComLock

There's should not be any direct reference to the "internal" node object.

const createdNode = connection.create(...)
const modifiedNode = connection.modify(...);

Today createdNode and modifiedNode points to the same "internal" node object.
So if you try to diff before and after the modify, there is no diff because the createdNode object was "also" modified.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions