Skip to content

Commit ad3f6cb

Browse files
committed
save
1 parent 79898bc commit ad3f6cb

File tree

2 files changed

+37
-9
lines changed

2 files changed

+37
-9
lines changed

modules/core/core-audit/src/main/java/com/enonic/xp/core/impl/audit/CleanUpAuditLogCommand.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
import com.enonic.xp.audit.CleanUpAuditLogListener;
1212
import com.enonic.xp.audit.CleanUpAuditLogResult;
1313
import com.enonic.xp.data.ValueFactory;
14+
import com.enonic.xp.node.DeleteNodeParams;
1415
import com.enonic.xp.node.FindNodesByQueryResult;
1516
import com.enonic.xp.node.NodeHit;
1617
import com.enonic.xp.node.NodeIndexPath;
@@ -74,11 +75,13 @@ private CleanUpAuditLogResult doCleanUp()
7475
{
7576
for ( NodeHit nodeHit : nodesToDelete.getNodeHits() )
7677
{
77-
result.deleted( nodeService.deleteById( nodeHit.getNodeId() ).getSize() );
78+
result.deleted( nodeService.delete( DeleteNodeParams.create().nodeId( nodeHit.getNodeId() ).build() )
79+
.getNodeBranchEntries()
80+
.getSize() );
7881

7982
listener.processed();
8083
}
81-
84+
nodeService.refresh( RefreshMode.SEARCH );
8285
nodesToDelete = nodeService.findByQuery( query );
8386

8487
hits = nodesToDelete.getHits();

modules/core/core-audit/src/test/java/com/enonic/xp/core/impl/audit/AuditLogServiceImplTest.java

Lines changed: 32 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import org.junit.jupiter.api.BeforeEach;
44
import org.junit.jupiter.api.Test;
5-
import org.mockito.ArgumentMatchers;
65

76
import com.enonic.xp.audit.AuditLog;
87
import com.enonic.xp.audit.AuditLogId;
@@ -18,12 +17,17 @@
1817
import com.enonic.xp.data.PropertyTree;
1918
import com.enonic.xp.index.IndexService;
2019
import com.enonic.xp.node.CreateNodeParams;
20+
import com.enonic.xp.node.DeleteNodeParams;
21+
import com.enonic.xp.node.DeleteNodeResult;
2122
import com.enonic.xp.node.FindNodesByQueryResult;
2223
import com.enonic.xp.node.Node;
24+
import com.enonic.xp.node.NodeBranchEntries;
25+
import com.enonic.xp.node.NodeBranchEntry;
2326
import com.enonic.xp.node.NodeHit;
2427
import com.enonic.xp.node.NodeHits;
2528
import com.enonic.xp.node.NodeId;
2629
import com.enonic.xp.node.NodeIds;
30+
import com.enonic.xp.node.NodePath;
2731
import com.enonic.xp.node.NodeQuery;
2832
import com.enonic.xp.node.NodeService;
2933
import com.enonic.xp.node.Nodes;
@@ -143,8 +147,15 @@ public void find()
143147
@Test
144148
public void cleanUpOneEmpty()
145149
{
146-
when( nodeService.deleteById( ArgumentMatchers.isA( NodeId.class ) ) ).thenAnswer(
147-
answer -> NodeIds.from( (NodeId) answer.getArgument( 0 ) ) );
150+
when( nodeService.delete( any() ) ).thenAnswer( answer -> DeleteNodeResult.create()
151+
.nodeBranchEntries( NodeBranchEntries.create()
152+
.add( NodeBranchEntry.create()
153+
.nodeId( answer.getArgument( 0, DeleteNodeParams.class ).getNodeId() )
154+
.nodePath( NodePath.ROOT )
155+
.build() )
156+
.build() )
157+
.build() );
158+
148159
when( config.ageThreshold() ).thenReturn( "PT1s" );
149160

150161
when( nodeService.findByQuery( any( NodeQuery.class ) ) ).
@@ -165,8 +176,15 @@ public void cleanUpOneEmpty()
165176
@Test
166177
public void cleanUpOneBatch()
167178
{
168-
when( nodeService.deleteById( ArgumentMatchers.isA( NodeId.class ) ) ).thenAnswer(
169-
answer -> NodeIds.from( (NodeId) answer.getArgument( 0 ) ) );
179+
when( nodeService.delete( any() ) ).thenAnswer( answer -> DeleteNodeResult.create()
180+
.nodeBranchEntries( NodeBranchEntries.create()
181+
.add( NodeBranchEntry.create()
182+
.nodeId( answer.getArgument( 0, DeleteNodeParams.class ).getNodeId() )
183+
.nodePath( NodePath.ROOT )
184+
.build() )
185+
.build() )
186+
.build() );
187+
170188
when( config.ageThreshold() ).thenReturn( "PT1s" );
171189

172190
final FindNodesByQueryResult.Builder queryResult = FindNodesByQueryResult.create().
@@ -194,8 +212,15 @@ public void cleanUpOneBatch()
194212
@Test
195213
public void cleanUpMultipleBatch()
196214
{
197-
when( nodeService.deleteById( ArgumentMatchers.isA( NodeId.class ) ) ).thenAnswer(
198-
answer -> NodeIds.from( (NodeId) answer.getArgument( 0 ) ) );
215+
when( nodeService.delete( any() ) ).thenAnswer( answer -> DeleteNodeResult.create()
216+
.nodeBranchEntries( NodeBranchEntries.create()
217+
.add( NodeBranchEntry.create()
218+
.nodeId( answer.getArgument( 0, DeleteNodeParams.class ).getNodeId() )
219+
.nodePath( NodePath.ROOT )
220+
.build() )
221+
.build() )
222+
.build() );
223+
199224
when( config.ageThreshold() ).thenReturn( "PT1s" );
200225

201226
final FindNodesByQueryResult.Builder queryResult1 = FindNodesByQueryResult.create().

0 commit comments

Comments
 (0)