improved error handling in checker

Author: st0ffregen

checker/src/checker.py

@@ -115,7 +115,7 @@ async def register_user(self, username: str, password: str) -> Tuple[int, int]:
             raise MumbleException(f"HTTP error during user registration.")
         except Exception as e:
             self.logger.error(f"Error during user registration: {e}")
-            raise MumbleException(f"Error during user registration: {e}")
+            raise MumbleException(f"Error during user registration.")
 
     async def login_user(self, username: str, password: str, set_token: bool = True) -> str:
         self.logger.debug(f"Logging in user: {username}")
@@ -184,10 +184,10 @@ async def import_session(self, session_id: int) -> int:
             raise MumbleException(f"Connection error during importing session.")
         except HTTPStatusError as e:
             self.logger.error(f"HTTPStatusError error during importing session with id {session_id}: {e}")
-            raise MumbleException(f"HTTPStatusError error during importing session with id {session_id}: {e}")
+            raise MumbleException(f"HTTPStatusError error during importing session.")
         except Exception as e:
             self.logger.error(f"Error during importing session with id {session_id}: {e}")
-            raise MumbleException(f"Error during importing session with id {session_id}: {e}")
+            raise MumbleException(f"Error during importing session.")
 
     async def search_collection(self, chat_session_id: int, query: str, top_k: int = 1, token: str = None) -> list:
         self.logger.debug(f"Searching chat session {chat_session_id} docs with query: {query}")
@@ -214,7 +214,7 @@ async def search_collection(self, chat_session_id: int, query: str, top_k: int =
             return documents
         except (ConnectTimeout, NetworkError, PoolTimeout, RequestError) as e:
             self.logger.error(f"Connection error during searching chat session {chat_session_id} with query {query}: {e}")
-            raise MumbleException(f"Connection error during chat session search-")
+            raise MumbleException(f"Connection error during chat session search.")
         except HTTPStatusError as e:
             self.logger.error(f"HTTP error during searching chat session {chat_session_id} with query {query}: {e}")
             raise MumbleException(f"HTTP error during chat session search.")
@@ -394,22 +394,14 @@ async def _run_session(self, read_stream, write_stream, chat_session_id):
     async def call_tool(self, tool_name: str, arguments: dict[str, Any] | None = None):
         self.logger.debug(f"Calling mcp tool {tool_name} with arguments {arguments}")
         if not self.session:
-            self.logger.error(f"Mcp session was established")
-            raise MumbleException("Mcp session was established")
+            self.logger.error(f"Mcp session was not established")
+            raise MumbleException("Mcp session was not established")
 
         messages = []
 
-        try:
-            result = await self.session.call_tool(tool_name, arguments or {})
-            if hasattr(result, "content") and len(result.content) == 1 and hasattr(result.content[0], "text"):
-                messages = json.loads(result.content[0].text)
-        except Exception as e:
-            self.logger.error(f"Failed to call mcp tool {tool_name}: {e}")
-            raise MumbleException(f"Failed to call mcp tool.")
-
-        if len(messages) == 0:
-            self.logger.error(f"MCP GetMessages response is empty for tool {tool_name} with arguments {arguments}")
-            raise MumbleException(f"Mcp response is empty.")
+        result = await self.session.call_tool(tool_name, arguments or {})
+        if hasattr(result, "content") and len(result.content) == 1 and hasattr(result.content[0], "text"):
+            messages = json.loads(result.content[0].text)
 
         self.logger.debug(f"Received messages {json.dumps(messages)} from tool {tool_name}")
         return messages