Merge pull request #16 from enricobattocchi/claude/fix-search-cache-QFBXY

fix(search): include term/locale in unstable_cache keyParts

Author: enricobattocchi

src/app/api/search/route.ts

@@ -14,9 +14,7 @@ export async function GET(request: NextRequest) {
 
   try {
     const events = await searchWikidata(sanitized, lang);
-    return NextResponse.json(events, {
-      headers: { "Cache-Control": "public, s-maxage=86400, stale-while-revalidate=604800" },
-    });
+    return NextResponse.json(events);
   } catch {
     return NextResponse.json(
       { error: "Failed to search Wikidata" },

src/lib/wikidata.test.ts

@@ -1,5 +1,5 @@
 import { describe, it, expect, vi, afterEach } from "vitest";
-import { bestClaim, fetchWithRetry, type WikidataClaim } from "./wikidata";
+import { bestClaim, fetchWithRetry, searchWikidata, type WikidataClaim } from "./wikidata";
 
 vi.mock("next/cache", () => ({
   unstable_cache: (fn: (...args: unknown[]) => unknown) => fn,
@@ -123,3 +123,22 @@ describe("bestClaim", () => {
     expect((result!.mainsnak.datavalue!.value as { time: string }).time).toBe("+2026-04-01T00:00:00Z");
   });
 });
+
+describe("searchWikidata", () => {
+  afterEach(() => {
+    vi.restoreAllMocks();
+  });
+
+  it("propagates the term into the Wikidata search URL", async () => {
+    const empty = () =>
+      new Response(JSON.stringify({ search: [] }), { status: 200 });
+    const fetchSpy = vi.spyOn(globalThis, "fetch").mockImplementation(async () => empty());
+
+    await searchWikidata("Napoleon", "en");
+    await searchWikidata("Leonardo", "en");
+
+    const urls = fetchSpy.mock.calls.map((c) => String(c[0]));
+    expect(urls.some((u) => u.includes("search=Napoleon"))).toBe(true);
+    expect(urls.some((u) => u.includes("search=Leonardo"))).toBe(true);
+  });
+});

src/lib/wikidata.ts

@@ -520,15 +520,16 @@ async function _searchWikidata(term: string, locale: string): Promise<Event[]> {
   return events.filter((e) => e.link);
 }
 
-const _cachedSearchWikidata = unstable_cache(
-  _searchWikidata,
-  ["wikidata-search"],
-  { revalidate: 86400, tags: ["wikidata"] }
-);
-
-/** Search Wikidata for events matching a search term (cross-request cached, 24h TTL) */
+/** Search Wikidata for events matching a search term.
+ *  Cached per (term, locale) for 24h — identical queries reuse the same entry,
+ *  different queries get distinct cache entries. */
 export async function searchWikidata(term: string, locale: string = "en"): Promise<Event[]> {
-  return _cachedSearchWikidata(term, locale);
+  const cached = unstable_cache(
+    () => _searchWikidata(term, locale),
+    ["wikidata-search", term, locale],
+    { revalidate: 86400, tags: ["wikidata"] }
+  );
+  return cached();
 }
 
 /** Fetch specific events by their Q-IDs (cross-request cached 24h + per-render deduplicated) */