Skip to content

Commit 1291416

Browse files
authored
Merge pull request #1010 from ensdomains/fet1859-safe-transactions-marked-as-failed
add guard to filter out safe transactions in sync dropped transactions
2 parents 0873924 + 51a69c3 commit 1291416

2 files changed

Lines changed: 4 additions & 0 deletions

File tree

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
"dev:https": "next dev --experimental-https --port 443",
99
"dev:https:holesky": "NEXT_PUBLIC_CHAIN_NAME=holesky pnpm dev:https",
1010
"dev:https:sepolia": "NEXT_PUBLIC_CHAIN_NAME=sepolia pnpm dev:https",
11+
"dev:https:mainnet": "NEXT_PUBLIC_CHAIN_NAME=mainnet pnpm dev:https",
1112
"dev:nlocal": "NEXT_PUBLIC_PROVIDER=http://localhost:8545 NEXT_PUBLIC_AVUP_ENDPOINT=http://localhost:8787 pnpm dev",
1213
"dev:localname": "NEXT_PUBLIC_PROVIDER=\"http://$(\"hostname\"):8545\" && NEXT_PUBLIC_AVUP_ENDPOINT=\"http://$(\"hostname\"):8787\" && NEXT_PUBLIC_GRAPH_URI=\"http://$(\"hostname\"):8000/subgraphs/name/graphprotocol/ens\" && pnpm dev",
1314
"dev:glocal": "SWC_CACHE=false rm -rf .next && NEXT_PUBLIC_GRAPH_URI=http://localhost:8000/subgraphs/name/graphprotocol/ens NEXT_PUBLIC_ETH_NODE=anvil pnpm dev:nlocal",

src/utils/SyncProvider/SyncDroppedTransaction.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,9 @@ export const findDroppedTransactions = async (
151151
return
152152
}
153153

154+
// If the transaction is a safe transaction, we don't need to retry it or check for cancellations
155+
if (searchingTransaction.isSafeTx) return
156+
154157
// If there is a transaction in history with a timestamp ahead of the searching transaction
155158
// at this point, then we can assume the searchingTransaction was cancelled
156159
const cancelledTransactions = accountTransactionHistory.filter(

0 commit comments

Comments
 (0)