Skip to content

Commit aea473c

Browse files
committed
CI: run make all before checking for uncommitted changes
Currently, `make test` is used to detect uncommitted file changes, but it missed some targets that modify files (e.g. "make docs"). Update the workflow to also run `make all`, to ensure that all relevant file-generating targets are executed before checking for uncommitted changes. Refs: https://issues.redhat.com/browse/EC-1262
1 parent 8935728 commit aea473c

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

.github/workflows/checks.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,9 @@ jobs:
3535
- name: Check go versions
3636
uses: enterprise-contract/github-workflows/golang-version-check@main
3737

38+
- name: Build all
39+
run: make all
40+
3841
- name: Test
3942
run: make test
4043

@@ -69,6 +72,7 @@ jobs:
6972
if ! git diff --exit-code -s; then
7073
for f in $(git diff --exit-code --name-only); do
7174
echo "::error file=$f,line=1,col=1,endColumn=1::File was modified in build"
75+
echo -e "\033[1;33mHint:\033[0m Maybe you need to run \033[1;32mmake all\033[0m"
7276
done
7377
exit 1
7478
fi

0 commit comments

Comments
 (0)