Skip to content

Attempt to run H5 tests on macOS Silicon again #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 12, 2025
Merged

Attempt to run H5 tests on macOS Silicon again #362

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bd89a2a
Attempt to run H5 tests on macOS Silicon again
mdickinson May 12, 2025
e1a8fb5
Restore split; run h5 tests on macOS for Python >= 3.10
mdickinson May 12, 2025
d07f3bd
Don't try to compare version strings as strings
mdickinson May 12, 2025
a410487
Try to fix expression syntax
mdickinson May 12, 2025
51c1a62
Update test-with-pip.yml
mdickinson May 12, 2025
6a3139b
Merge branch 'main' into fix/drop-macos-h5-test-exclusion
mdickinson May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/workflows/test-with-pip.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,15 @@ jobs:
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
- name: Install dependencies and local packages (not macOS)
- name: Install dependencies and local packages
run: python -m pip install .[gui,h5,preferences]
if: matrix.os != 'macos-latest'
- name: Install dependencies and local packages (macOS)
if: (matrix.os != 'macos-latest') || ((matrix.python-version != '3.8') && (matrix.python-version != '3.9'))
- name: Install dependencies and local packages (exclude h5)
run: python -m pip install .[gui,preferences]
# PyTables currently won't build on Apple Silicon, so exclude the h5 deps
# PyTables won't build on Apple Silicon for Python < 3.10, so exclude
# the h5 dependency.
# xref: enthought/apptools/issues/344
if: matrix.os == 'macos-latest'
if: (matrix.os == 'macos-latest') && ((matrix.python-version == '3.8') || (matrix.python-version == '3.9'))
- name: Run tests
run: |
mkdir testdir
Expand Down
Loading