[WIP] Non-uniformly sampled 2d plots #325
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work needs to be done on integration, particularly the Plot classes insistence on resampling, plus disambiguation of cell-based vs. vertex based data.
Collaborator
|
I haven't looked at the details, but noticed that you have checked in the .c file. I am assuming that's unintentional since it is generated, so I thought I would drop a note. |
Contributor
Author
|
It's intentional: for Enable and Chaco we include the .c file so that things can be built without having to have Cython installed. Developers have to be good and remember to update the .c file if they make changes to the Cython code. |
Member
|
What about requiring Cython for developers tracking the master branch, but including the .c file in the sdist? |
Collaborator
|
+1 for @jwiggins 's suggestion. |
Contributor
Author
|
That's a reasonable suggestion, but probably not as part of this PR. |
Collaborator
|
Agreed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a new plot type that displays a pixel at points on a (possibly non-uniformly sampled) grid, and correctly handles downsampling when zoomed out. This is particularly intended for multi-valued time-series data which may not be uniformly sampled in time, such as you might get from real-world distributed acoustic sensing.
Includes fast 2d downsampling in Cython, which may be of use to other plots as well.
Needs unit tests.
There may be some discussion required around what to do when zoomed far in - single pixels are not as compelling as other markers; maybe should display at lower resolution?