Some problems with wine on linux

[itziakos]

It looks that there are incompatibilities with the wine implementations of

• EnumResourceTypesW -- When there are no resource types to enumerate the function instead of True will return False (see https://github.com/wine-mirror/wine/blob/master/dlls/kernel32/resource.c#L250)
• BeginUpdateResourceW -- will return a Null handle if the filename is invalid but will not set a proper errorno (https://github.com/wine-mirror/wine/blob/master/dlls/kernel32/resource.c#L1655))
• EndUpdateResourceW -- will return False if the handle is invalid but will not set a proper errorno(https://github.com/wine-mirror/wine/blob/master/dlls/kernel32/resource.c#L1715)

[stuaxo]

It's worth reporting these to wine bugzilla https://bugs.winehq.org/ there's an even chance someone will turn up to fix it.

[stuaxo]

Let me know if your happy for me to upstream these to wine, it looks like there is enough info for them to fix these? Though my win32 knowledge is pretty lacking.

[itziakos]

Sure, feel free to report the issues. The primary target platform for pywin32-ctypes is windows so, supporting wine is not at the moment high up in the priorities. Testing on wine was an early necessity (and kind of a cool thing to do) so that we could have automatic testing using travis-ci. Switching to appveyor made it unnecessary, so I removed it.

[stuaxo]

Bug 46254 - EnumResourceTypesW should return True if there are no resources to enumerate
https://bugs.winehq.org/show_bug.cgi?id=46254

Bug 46255 - BeginUpdateResourceW should set errno on invalid filename
https://bugs.winehq.org/show_bug.cgi?id=46255

Bug 46256 - EndUpdateResourceW should set errno on invalid handle
https://bugs.winehq.org/show_bug.cgi?id=46256

[stuaxo]

Any idea if this still happens ?

(it looks like maybe not from the last comment on the bug here)
https://bugs.winehq.org/show_bug.cgi?id=46254

[itziakos]

Any idea if this still happens ?

(it looks like maybe not from the last comment on the bug here) https://bugs.winehq.org/show_bug.cgi?id=46254

The code in wine has changed and the EnumResourceTypesW now calls EnumResourceTypesExW (in https://github.com/wine-mirror/wine/blob/f1b2e2ca1bbd464424ead53a1ea45077ca45472a/dlls/kernelbase/loader.c#L1003). I think that the issue is still there and the function will return False (which is often represented as 0), instead of the True.

[stuaxo]

I wonder if Wine has conformance tests around these APIs that cover these cases..
https://gitlab.winehq.org/wine/wine/-/wikis/Conformance-Tests

[stuaxo]

@itziakos there are some in progress patches on the WineHQ bug.