-
Notifications
You must be signed in to change notification settings - Fork 2
Open
Labels
type: refactorCleanup or refactoring tasks that don't add functionality or fix bugsCleanup or refactoring tasks that don't add functionality or fix bugs
Milestone
Description
#392 refactored what's now the BaseTask to add a new ABANDONED message type, used for cancellation. That fixed a situation where we were inventing a bogus return value of None when the task wasn't even being executed.
But individual tasks are still inventing a bogus return value of None in response to cancellation. We could fix up the BaseTask to make it easier to check for cancellation and send the ABANDONED message if cancellation occurred.
Examples of the bogus return value:
return None return None
Metadata
Metadata
Assignees
Labels
type: refactorCleanup or refactoring tasks that don't add functionality or fix bugsCleanup or refactoring tasks that don't add functionality or fix bugs