Remove v2 checkpoint write gate

Entire-Checkpoint: 58d96f1248ed

Author: computermode

cmd/entire/cli/settings/settings.go

@@ -969,27 +969,6 @@ func CheckpointsVersion(ctx context.Context) int {
 	return version
 }
 
-// CheckpointsWriteVersion returns the checkpoint version used for new writes.
-// Checkpoints v2 settings are no longer supported for writes, so legacy v2
-// configuration falls back to v1.
-func CheckpointsWriteVersion(ctx context.Context) int {
-	s, err := Load(ctx)
-	if err != nil {
-		return 1
-	}
-	return s.CheckpointsWriteVersion()
-}
-
-// IsCheckpointsV2WriteEnabled returns whether new writes should create v2
-// checkpoint refs. Legacy settings are disallowed for writes, so this is false.
-func IsCheckpointsV2WriteEnabled(ctx context.Context) bool {
-	s, err := Load(ctx)
-	if err != nil {
-		return false
-	}
-	return s.IsCheckpointsV2WriteEnabled()
-}
-
 // WarnIfCheckpointsV2Disallowed emits the user-facing fallback warning when a
 // settings file still requests checkpoints v2. Call this from push-time flows
 // so users learn why v1 metadata is being pushed instead.
@@ -1083,8 +1062,7 @@ func (s *EntireSettings) GetCheckpointRemote() *CheckpointRemoteConfig {
 }
 
 // IsCheckpointsV2Enabled checks if checkpoints v2 is enabled for read paths.
-// Writes use IsCheckpointsV2WriteEnabled instead so existing v2 checkpoint
-// metadata remains readable while new writes fall back to v1.
+// Existing v2 checkpoint metadata remains readable while new writes use v1.
 func (s *EntireSettings) IsCheckpointsV2Enabled() bool {
 	if s.StrategyOptions == nil {
 		return false
@@ -1119,18 +1097,6 @@ func (s *EntireSettings) CheckpointsVersion() int {
 	return 1
 }
 
-// IsCheckpointsV2WriteEnabled always returns false. Legacy checkpoints v2
-// settings are read-compatible but no longer enable new v2 writes.
-func (s *EntireSettings) IsCheckpointsV2WriteEnabled() bool {
-	return false
-}
-
-// CheckpointsWriteVersion returns the checkpoint version used for writes.
-// Writes always use v1 now, even when legacy settings request v2.
-func (s *EntireSettings) CheckpointsWriteVersion() int {
-	return 1
-}
-
 // WarnIfCheckpointsV2Disallowed emits the v2 fallback warning when any legacy
 // settings key requests v2 writes or pushes.
 func (s *EntireSettings) WarnIfCheckpointsV2Disallowed() {

cmd/entire/cli/settings/settings_test.go

@@ -855,57 +855,6 @@ func TestCheckpointsVersion(t *testing.T) {
 	}
 }
 
-func TestCheckpointsWriteVersion(t *testing.T) {
-	t.Parallel()
-
-	tests := []struct {
-		name string
-		opts map[string]any
-		want int
-	}{
-		{"unset defaults to one", nil, 1},
-		{"empty options defaults to one", map[string]any{}, 1},
-		{"integer 2 disallowed for writes", map[string]any{"checkpoints_version": 2}, 1},
-		{"float 2 disallowed for writes", map[string]any{"checkpoints_version": float64(2)}, 1},
-		{"string 2 disallowed for writes", map[string]any{"checkpoints_version": "2"}, 1},
-		{"integer 1 remains one", map[string]any{"checkpoints_version": 1}, 1},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			t.Parallel()
-			s := &EntireSettings{StrategyOptions: tt.opts}
-			if got := s.CheckpointsWriteVersion(); got != tt.want {
-				t.Errorf("CheckpointsWriteVersion() = %d, want %d", got, tt.want)
-			}
-		})
-	}
-}
-
-func TestIsCheckpointsV2WriteEnabled_AlwaysFalseAfterDisallow(t *testing.T) {
-	t.Parallel()
-
-	tests := []struct {
-		name string
-		opts map[string]any
-	}{
-		{"checkpoints_version 2", map[string]any{"checkpoints_version": 2}},
-		{"checkpoints_v2 true", map[string]any{"checkpoints_v2": true}},
-		{"both true", map[string]any{"checkpoints_v2": true, "checkpoints_version": 2}},
-		{"empty options", map[string]any{}},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			t.Parallel()
-			s := &EntireSettings{StrategyOptions: tt.opts}
-			if s.IsCheckpointsV2WriteEnabled() {
-				t.Error("expected IsCheckpointsV2WriteEnabled to be false")
-			}
-		})
-	}
-}
-
 func TestWarnIfCheckpointsV2Disallowed(t *testing.T) {
 	tests := []struct {
 		name     string