[cleanup]Centralize form accessibility behavior#1391
Open
stale2000 wants to merge 1 commit into
Open
Conversation
stale2000
force-pushed
the
codex/unify-uiform-accessibility
branch
from
4f6d19a to
a2492d6
Compare
stale2000
changed the title
stale2000
force-pushed
the
codex/unify-uiform-accessibility
branch
from
e4bab32 to
a2492d6
Compare
The CLI already has a uiform helper for applying the standard huh theme and ACCESSIBLE handling. Routing the remaining manual form construction through that helper keeps accessibility behavior from drifting across prompts. Constraint: Accessibility behavior is an explicit CLI contract and should have one production form-construction path. Constraint: Keep the strategy package's isAccessibleMode helper available for prompts that cannot use uiform.New directly. Confidence: high Scope-risk: narrow Directive: New production huh forms should go through uiform.New rather than calling huh.NewForm directly. Tested: go test ./cmd/entire/cli/uiform ./cmd/entire/cli/versioncheck ./cmd/entire/cli/strategy; mise run lint Not-tested: Full mise run check still has the known unrelated TestRunAuthStatus_RendersSessionsTable date expectation failure Entire-Checkpoint: b67692b53719
stale2000
force-pushed
the
codex/unify-uiform-accessibility
branch
from
a2492d6 to
0cc8b18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entire Logs: https://entire.io/gh/stale2000/cli/session/019ea9df-d0d9-7c41-a8dc-91ed5d127d35
Summary
uiform.Newhuh.NewFormusage stays centralized inuiformVerification
go test ./cmd/entire/cli/uiform ./cmd/entire/cli/versioncheck ./cmd/entire/cli/strategymise run lintmise run checkreached the full test phase after passing fmt/lint, but failed on existing unrelatedTestRunAuthStatus_RendersSessionsTabledate expectation: expected2026-01-01, rendered2025-12-31.Checkpoint Metadata
Commit includes
Entire-Checkpoint: 9234c35440b2.