Skip to content

Commit a5fce9e

Browse files
authored
Merge pull request #203 from entrylabs/issue/codesign_notarytool
notarytool 사용을 위해 teamID 추가
2 parents eaab02b + 3357113 commit a5fce9e

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

scripts/notarize.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
const { notarize } = require('electron-notarize');
22

33
module.exports = async function notarizing(notarizeOption) {
4-
const { appBundleId, appPath, appleId, appleIdPassword } = notarizeOption;
4+
const { appBundleId, appPath, appleId, appleIdPassword, teamId } = notarizeOption;
55
const { NOTARIZE } = process.env;
66

77
// noinspection EqualityComparisonWithCoercionJS
@@ -10,8 +10,8 @@ module.exports = async function notarizing(notarizeOption) {
1010
return;
1111
}
1212

13-
if (!appleId || !appleIdPassword) {
14-
console.log(' • APPLE_ID or APPLE_PASSWORD not found. will be skipped this process');
13+
if (!appleId || !appleIdPassword || !teamId) {
14+
console.log(' • APPLE_ID or APPLE_PASSWORD or TEAM_ID not found. will be skipped this process');
1515
return;
1616
}
1717

@@ -21,9 +21,11 @@ module.exports = async function notarizing(notarizeOption) {
2121
appleId: ${appleId}`,
2222
);
2323
return await notarize({
24+
tool: 'notarytool',
2425
appBundleId,
2526
appPath,
2627
appleId,
28+
teamId,
2729
appleIdPassword,
2830
});
2931
};

scripts/notarize_app.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ const notarize = require('./notarize');
33
module.exports = async function notarizing(context) {
44
const { appOutDir } = context;
55
const { electronPlatformName } = context;
6-
const { APPLE_ID, APPLE_PASSWORD } = process.env;
6+
const { APPLE_ID, APPLE_PASSWORD, TEAM_ID } = process.env;
77

88
if (electronPlatformName !== 'darwin') {
99
return;
@@ -15,6 +15,7 @@ module.exports = async function notarizing(context) {
1515
appBundleId: 'org.playentry.entry',
1616
appPath: `${appOutDir}/${appName}.app`,
1717
appleId: APPLE_ID,
18+
teamId: TEAM_ID,
1819
appleIdPassword: APPLE_PASSWORD,
1920
});
2021
};

scripts/notarize_installer.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,15 @@ const notarize = require('./notarize');
33

44
module.exports = async (context) => {
55
const { artifactPaths } = context;
6-
const { APPLE_ID, APPLE_PASSWORD } = process.env;
6+
const { APPLE_ID, APPLE_PASSWORD, TEAM_ID } = process.env;
77

88
return await Promise.all(artifactPaths.map(async (artifactPath) => {
99
if (path.extname(artifactPath) === '.pkg') {
1010
return await notarize({
1111
appBundleId: 'org.playentry.entry',
1212
appPath: artifactPath,
1313
appleId: APPLE_ID,
14+
teamId: TEAM_ID,
1415
appleIdPassword: APPLE_PASSWORD,
1516
});
1617
}

0 commit comments

Comments
 (0)