ci: separate out precommit job into a different workflow (#918)

**Description**

Previously, the precommit check was only running on the code changes
since it exists inside the build_and_test.yaml workflow since #774. This
was a problematic when, for example, the PR only changing the
documentation was opened because the spellchecks etc were not running on
that PR. This essentially reverts #774.

---------

Signed-off-by: Takeshi Yoneda <[email protected]>

Author: mathetake

.github/workflows/build_and_test.yaml

@@ -33,34 +33,8 @@ permissions:
   packages: write
 
 jobs:
-  style:
-    name: Check
-    strategy:
-      fail-fast: false
-      matrix:
-        os:
-          - ubuntu-latest
-          - macos-latest
-    runs-on: ${{ matrix.os }}
-    steps:
-      - uses: actions/checkout@v4
-      - uses: actions/setup-go@v5
-        with:
-          cache: false
-          go-version-file: go.mod
-      - uses: actions/cache@v4
-        with:
-          path: |
-            ~/.cache/go-build
-            ~/.cache/golangci-lint
-            ~/go/pkg/mod
-            ~/go/bin
-          key: code-style-check-${{ hashFiles('**/go.mod', '**/go.sum', '**/Makefile') }}
-      - name: Ensure `make precommit` is executed
-        run: make check
   unittest:
     name: Unit Test
-    needs: [style]
     strategy:
       fail-fast: false
       matrix:
@@ -100,7 +74,6 @@ jobs:
 
   test_crdcel:
     name: CRD CEL Validation Test
-    needs: [style]
     runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false
@@ -125,7 +98,6 @@ jobs:
 
   test_controller:
     name: Controller Test
-    needs: [style]
     runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false
@@ -150,7 +122,6 @@ jobs:
 
   test_extproc:
     name: External Processor Test (Envoy v${{ matrix.version }} on ${{ matrix.os }})
-    needs: [style]
     strategy:
       fail-fast: false
       matrix:
@@ -209,7 +180,6 @@ jobs:
     # virtualization is not supported on macOS runners.
     # E.g. Use https://github.com/douglascamata/setup-docker-macos-action  per the comment in
     # https://github.com/actions/runner-images/issues/17#issuecomment-1971073406
-    needs: [style]
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false

.github/workflows/precommit_check.yaml

@@ -0,0 +1,48 @@
+# This is intentionally a separate workflow file than build_and_test.yaml since we want to run the precommit check on
+# any PRs regardless of the files changed, including documentation changes, etc.
+name: Precommit Check
+on:
+  pull_request:
+    branches:
+      - 'main'
+      - 'release/**'
+
+  push:
+    branches:
+      - 'main'
+      - 'release/**'
+
+concurrency:
+  # https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-using-concurrency-to-cancel-any-in-progress-job-or-run
+  group: ${{ github.ref }}-${{ github.workflow }}-${{ github.actor }}-${{ github.event_name }}
+  cancel-in-progress: true
+
+permissions:
+  contents: read
+
+jobs:
+  style:
+    name: Check
+    strategy:
+      fail-fast: false
+      matrix:
+        os:
+          - ubuntu-latest
+          - macos-latest
+    runs-on: ${{ matrix.os }}
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-go@v5
+        with:
+          cache: false
+          go-version-file: go.mod
+      - uses: actions/cache@v4
+        with:
+          path: |
+            ~/.cache/go-build
+            ~/.cache/golangci-lint
+            ~/go/pkg/mod
+            ~/go/bin
+          key: code-style-check-${{ hashFiles('**/go.mod', '**/go.sum', '**/Makefile') }}
+      - name: Ensure `make precommit` is executed
+        run: make check

docs/proposals/003-epp-integration-proposal/proposal.md

@@ -659,14 +659,14 @@ sequenceDiagram
     AIServer->>EG: List/Watch Envoy Gateway CRDs (Gateway/HTTPRoute/EnvoyExtensionPolicy/Backend)
     Note over EG: Translate CRDs to xDS configuration
     Note over EAGES: Implemented PostRouteModify/PostClusterModify/PostTranslateModify Hooks
-    EG->>EAGES: Invoke PostRouteModify Hook 
+    EG->>EAGES: Invoke PostRouteModify Hook
     EAGES-->>EG: Modify Envoy Route Config (Add EPP Metadata)
-    EG->>EAGES: Invoke PostClusterModify Hook 
+    EG->>EAGES: Invoke PostClusterModify Hook
     EAGES-->>EG: Modify Envoy Cluster Config (Modify Cluster with HostOverride LBPolicy or Original Dst)
-    EG->>EAGES: Invoke PostTranslateModify Hook 
+    EG->>EAGES: Invoke PostTranslateModify Hook
     EAGES-->>EG: Modify Envoy Listeners and Routes Config (Insert EPP extproc in relevant listeners and disable EPP extproc in un related routes)
     EG ->> Proxy: Generate final xDS configuration
-    Note over Proxy: Ready to foward downstream requests
+    Note over Proxy: Ready to forward downstream requests
 ```
 
 The logics flow for HTTPRoute + InferencePool is like:
@@ -681,14 +681,14 @@ sequenceDiagram
     AIServer->>EG: List/Watch Envoy Gateway CRDs (Gateway/HTTPRoute/EnvoyExtensionPolicy/Backend)
     Note over EG: Translate CRDs to xDS configuration
     Note over EAGES: Implemented PostRouteModify/PostClusterModify/PostTranslateModify Hooks
-    EG->>EAGES: Invoke PostRouteModify Hook 
+    EG->>EAGES: Invoke PostRouteModify Hook
     EAGES-->>EG: Modify Envoy Route Config (Add EPP Metadata)
-    EG->>EAGES: Invoke PostClusterModify Hook 
+    EG->>EAGES: Invoke PostClusterModify Hook
     EAGES-->>EG: Modify Envoy Cluster Config (Modify Cluster with HostOverride LBPolicy or Original Dst)
-    EG->>EAGES: Invoke PostTranslateModify Hook 
+    EG->>EAGES: Invoke PostTranslateModify Hook
     EAGES-->>EG: Modify Envoy Listeners and Routes Config (Insert EPP extproc in relevant listeners and disable EPP extproc in un related routes)
     EG ->> Proxy: Generate final xDS configuration
-    Note over Proxy: Ready to foward downstream requests
+    Note over Proxy: Ready to forward downstream requests
 ```
 
 ## Request Flow
@@ -715,7 +715,7 @@ sequenceDiagram
     EPP-->>Envoy: Add Picked Endpoint in Header and Metadata;
 
     loop Retry/Fallback loop
-    Note over Envoy: Foward Based on Picked Endpoint (Original Dst or HostOverride LbPolicy)
+    Note over Envoy: Forward Based on Picked Endpoint (Original Dst or HostOverride LbPolicy)
     Envoy->>Processor: Upstream level ExtProc Request
     Note over Processor: Request-Transform
     Processor-->>Envoy: ;
@@ -746,7 +746,7 @@ sequenceDiagram
     EPP-->>Envoy: Add Picked Endpoint in Header and Metadata;
 
     loop Retry/Fallback loop
-    Note over Envoy: Foward Based on Picked Endpoint (Original Dst or HostOverride LbPolicy)
+    Note over Envoy: Forward Based on Picked Endpoint (Original Dst or HostOverride LbPolicy)
     Envoy->>SelfHosted: Forward Request
     SelfHosted-->>Envoy: Response
     end