fix lint issues in vertex ai image generation translator

Author: altale

internal/apischema/gcp/gcp.go

@@ -132,7 +132,7 @@ type ImageParameters struct {
 // ImageOutputOptions specifies the output format and compression for generated images.
 type ImageOutputOptions struct {
 	MIMEType           string `json:"mimeType,omitempty"`
-	CompressionQuality *int    `json:"compressionQuality,omitempty"`
+	CompressionQuality *int   `json:"compressionQuality,omitempty"`
 }
 
 // ImagePrediction is a single image in the Imagen predict response.

internal/translator/imagegeneration_openai_gcpvertexai.go

@@ -13,13 +13,14 @@ import (
 	"strings"
 	"time"
 
+	"google.golang.org/genai"
+
 	"github.com/envoyproxy/ai-gateway/internal/apischema/gcp"
 	"github.com/envoyproxy/ai-gateway/internal/apischema/openai"
 	"github.com/envoyproxy/ai-gateway/internal/internalapi"
 	"github.com/envoyproxy/ai-gateway/internal/json"
 	"github.com/envoyproxy/ai-gateway/internal/metrics"
 	"github.com/envoyproxy/ai-gateway/internal/tracing/tracingapi"
-	"google.golang.org/genai"
 )
 
 // NewImageGenerationOpenAIToGCPVertexAITranslator implements [Factory] for OpenAI to GCP Vertex AI
@@ -41,7 +42,7 @@ type openAIToGCPVertexAIImageGenerationTranslator struct {
 	isImagenModel bool
 }
 
-func (o *openAIToGCPVertexAIImageGenerationTranslator) RequestBody(original []byte, openAIReq *openai.ImageGenerationRequest, forceBodyMutation bool) (
+func (o *openAIToGCPVertexAIImageGenerationTranslator) RequestBody(_ []byte, openAIReq *openai.ImageGenerationRequest, _ bool) (
 	newHeaders []internalapi.Header, newBody []byte, err error,
 ) {
 	o.requestModel = cmp.Or(o.modelNameOverride, openAIReq.Model)
@@ -58,15 +59,15 @@ func (o *openAIToGCPVertexAIImageGenerationTranslator) RequestBody(original []by
 			return
 		}
 		newBody, err = json.Marshal(imgGenReq)
-		path = buildGCPModelPathSuffix(gcpModelPublisherGoogle, string(o.requestModel), gcpMethodPredict)
+		path = buildGCPModelPathSuffix(gcpModelPublisherGoogle, o.requestModel, gcpMethodPredict)
 	} else {
 		var geminiReq *gcp.GenerateContentRequest
 		geminiReq, err = openAIToGeminiRequest(openAIReq)
 		if err != nil {
 			return
 		}
 		newBody, err = json.Marshal(geminiReq)
-		path = buildGCPModelPathSuffix(gcpModelPublisherGoogle, string(o.requestModel), gcpMethodGenerateContent)
+		path = buildGCPModelPathSuffix(gcpModelPublisherGoogle, o.requestModel, gcpMethodGenerateContent)
 	}
 	if err != nil {
 		err = fmt.Errorf("failed to encode request: %w", err)
@@ -148,7 +149,7 @@ func openAIToImagenRequest(req *openai.ImageGenerationRequest) (*gcp.ImagePredic
 			{Prompt: req.Prompt},
 		},
 		Parameters: &gcp.ImageParameters{
-			SampleCount:     int(cmp.Or(req.N, 1)),
+			SampleCount:     cmp.Or(req.N, 1),
 			AspectRatio:     aspectRatio,
 			SampleImageSize: sampleImageSize,
 			OutputOptions:   outputOptions,
@@ -183,7 +184,7 @@ func openAIToGeminiRequest(req *openai.ImageGenerationRequest) (*gcp.GenerateCon
 			},
 		},
 		GenerationConfig: &genai.GenerationConfig{
-			CandidateCount: int32(cmp.Or(req.N, 1)),
+			CandidateCount: int32(cmp.Or(req.N, 1)), //nolint:gosec
 		},
 	}, nil
 }
@@ -254,9 +255,9 @@ func geminiToOpenAIResponse(resp *genai.GenerateContentResponse, tokenUsage *met
 			InputTokens:  int(inputTokens),
 			OutputTokens: int(outputTokens),
 		}
-		tokenUsage.SetInputTokens(uint32(inputTokens))
-		tokenUsage.SetOutputTokens(uint32(outputTokens))
-		tokenUsage.SetTotalTokens(uint32(totalTokens))
+		tokenUsage.SetInputTokens(uint32(inputTokens))   //nolint:gosec
+		tokenUsage.SetOutputTokens(uint32(outputTokens)) //nolint:gosec
+		tokenUsage.SetTotalTokens(uint32(totalTokens))   //nolint:gosec
 	}
 
 	return &openai.ImageGenerationResponse{

internal/translator/imagegeneration_openai_gcpvertexai_test.go

@@ -266,7 +266,7 @@ func TestGCPVertexAIImageGeneration_ResponseBody_Imagen(t *testing.T) {
 	require.NoError(t, err)
 	require.NotNil(t, headers)
 	require.Equal(t, contentLengthHeaderName, headers[0].Key())
-	require.Equal(t, "imagen-4.0-generate-001", string(responseModel))
+	require.Equal(t, "imagen-4.0-generate-001", responseModel)
 
 	var got openai.ImageGenerationResponse
 	require.NoError(t, json.Unmarshal(body, &got))
@@ -275,7 +275,7 @@ func TestGCPVertexAIImageGeneration_ResponseBody_Imagen(t *testing.T) {
 	require.Equal(t, "enhanced prompt", got.Data[0].RevisedPrompt)
 	require.Equal(t, "aW1hZ2VkYXRhMg==", got.Data[1].B64JSON)
 	require.Equal(t, "png", got.OutputFormat)
-	require.True(t, got.Created > 0)
+	require.Positive(t, got.Created)
 
 	// Imagen has no token usage.
 	inputTokens, inputOk := tokenUsage.InputTokens()
@@ -340,7 +340,7 @@ func TestGCPVertexAIImageGeneration_ResponseBody_Gemini(t *testing.T) {
 
 	_, body, tokenUsage, responseModel, err := tr.ResponseBody(nil, bytes.NewReader(respBody), false, nil)
 	require.NoError(t, err)
-	require.Equal(t, "gemini-2.0-flash-exp", string(responseModel))
+	require.Equal(t, "gemini-2.0-flash-exp", responseModel)
 
 	var got openai.ImageGenerationResponse
 	require.NoError(t, json.Unmarshal(body, &got))

tests/data-plane/testupstream_test.go

@@ -190,7 +190,7 @@ func TestWithTestUpstream(t *testing.T) {
 				require.Equal(t, "aW1hZ2VkYXRh", resp.Data[0].B64JSON)
 				require.Equal(t, "aW1hZ2VkYXRhMg==", resp.Data[1].B64JSON)
 				require.Equal(t, "png", resp.OutputFormat)
-				require.True(t, resp.Created > 0)
+				require.Positive(t, resp.Created)
 			},
 		},
 		{