Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: envoyproxy/ai-gateway
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 89459498ad8383dbf23f4447b47f631e7379abb9
Choose a base ref
..
head repository: envoyproxy/ai-gateway
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e13393a4f3b60f95808512c4edc0099adf47f5ba
Choose a head ref
5 changes: 5 additions & 0 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
blank_issues_enabled: false
contact_links:
- name: "Crash bug"
url: https://github.com/envoyproxy/envoy/security/policy
about: "Please file any crash bug with envoy-security@googlegroups.com."
15 changes: 15 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
name: Feature request
about: Suggest an idea for this project
title: ''
labels: enhancement,triage
assignees: ''

---

*Description*:
>Describe the desired behavior, what scenario it enables and how it
would be used.

[optional *Relevant Links*:]
>Any extra documentation required to understand the issue.
26 changes: 26 additions & 0 deletions .github/ISSUE_TEMPLATE/non--crash-security--bug.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
---
name: Bug
about: Bugs
title: ''
labels: bug,triage
assignees: ''

---

*Description*:
>What issue is being seen? Describe what should be happening instead of
the bug, for example: Envoy should not crash, the expected value isn't
returned, etc.

*Repro steps*:
> Include sample requests, environment, etc. All data and inputs
required to reproduce the bug.

>**Note**: If there are privacy concerns, sanitize the data prior to
sharing.

*Environment*:
>Include the environment like gateway version, envoy version and so on.
*Logs*:
>Include the access logs and the Envoy logs.
14 changes: 14 additions & 0 deletions .github/ISSUE_TEMPLATE/other.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
name: Other
about: Questions, design proposals, tech debt, etc.
title: ''
labels: triage
assignees: ''

---

*Description*:
>Describe the issue.
[optional *Relevant Links*:]
>Any extra documentation required to understand the issue.
2 changes: 1 addition & 1 deletion filterconfig/filterconfig.go
Original file line number Diff line number Diff line change
@@ -171,7 +171,7 @@ type AWSAuth struct{}

// APIKeyAuth defines the file that will be mounted to the external proc.
type APIKeyAuth struct {
Filename string `yaml:"filename"`
Filename string `json:"filename"`
}

// UnmarshalConfigYaml reads the file at the given path and unmarshals it into a Config struct.
8 changes: 4 additions & 4 deletions internal/controller/ai_service_backend_test.go
Original file line number Diff line number Diff line change
@@ -2,19 +2,19 @@ package controller

import (
"context"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/utils/ptr"
"sigs.k8s.io/controller-runtime/pkg/client"
gwapiv1 "sigs.k8s.io/gateway-api/apis/v1"
"testing"

"github.com/stretchr/testify/require"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/types"
fake2 "k8s.io/client-go/kubernetes/fake"
"k8s.io/utils/ptr"
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/client/fake"
"sigs.k8s.io/controller-runtime/pkg/reconcile"
gwapiv1 "sigs.k8s.io/gateway-api/apis/v1"

aigv1a1 "github.com/envoyproxy/ai-gateway/api/v1alpha1"
)
1 change: 1 addition & 0 deletions internal/controller/sink_test.go
Original file line number Diff line number Diff line change
@@ -463,6 +463,7 @@ func TestConfigSink_SyncExtprocDeployment(t *testing.T) {

err = fakeClient.Create(context.Background(), aiGatewayRoute, &client.CreateOptions{})
require.NoError(t, err)

t.Run("create", func(t *testing.T) {
err = s.syncExtProcDeployment(context.Background(), aiGatewayRoute)
require.NoError(t, err)