check of size of trace_id

Signed-off-by: therealak12 <[email protected]>

Author: therealak12

source/extensions/tracers/opentelemetry/samplers/trace_id_ratio_based/BUILD

@@ -26,6 +26,8 @@ envoy_cc_library(
     srcs = ["trace_id_ratio_based_sampler.cc"],
     hdrs = ["trace_id_ratio_based_sampler.h"],
     deps = [
+        # "//source/common/common:minimal_logger_lib",
+        "//source/common/common:logger_lib",
         "//source/common/common:safe_memcpy_lib",
         "//source/extensions/tracers/opentelemetry:opentelemetry_tracer_lib",
         "//source/extensions/tracers/opentelemetry/samplers:sampler_lib",

source/extensions/tracers/opentelemetry/samplers/trace_id_ratio_based/trace_id_ratio_based_sampler.cc

@@ -9,18 +9,27 @@
 
 #include "envoy/type/v3/percent.pb.h"
 
+#include "source/common/common/logger.h"
 #include "source/common/common/safe_memcpy.h"
 #include "source/extensions/tracers/opentelemetry/span_context.h"
 
-namespace {
+namespace Envoy {
+namespace Extensions {
+namespace Tracers {
+namespace OpenTelemetry {
 
 /**
  * @param trace_id a required value to be converted to uint64_t. trace_id must
  * at least 8 bytes long. trace_id is expected to be a valid hex string.
  * @return Returns the uint64 value associated with first 8 bytes of the trace_id.
  *
  */
-uint64_t traceIdToUint64(const std::string& trace_id) noexcept {
+uint64_t TraceIdRatioBasedSampler::traceIdToUint64(const std::string& trace_id) noexcept {
+  if (trace_id.size() < 16) {
+    ENVOY_LOG(warn, "Trace ID is not long enough: {}", trace_id);
+    return 0;
+  }
+
   uint8_t buffer[8] = {0};
   for (size_t i = 0; i < 8; ++i) {
     std::string byte_string = trace_id.substr(i * 2, 2);
@@ -32,12 +41,6 @@ uint64_t traceIdToUint64(const std::string& trace_id) noexcept {
 
   return first_8_bytes;
 }
-} // namespace
-
-namespace Envoy {
-namespace Extensions {
-namespace Tracers {
-namespace OpenTelemetry {
 
 TraceIdRatioBasedSampler::TraceIdRatioBasedSampler(
     const envoy::extensions::tracers::opentelemetry::samplers::v3::TraceIdRatioBasedSamplerConfig&

source/extensions/tracers/opentelemetry/samplers/trace_id_ratio_based/trace_id_ratio_based_sampler.h

@@ -31,6 +31,7 @@ class TraceIdRatioBasedSampler : public Sampler, Logger::Loggable<Logger::Id::tr
                               OptRef<const Tracing::TraceContext> trace_context,
                               const std::vector<SpanContext>& links) override;
   std::string getDescription() const override;
+  uint64_t traceIdToUint64(const std::string& trace_id) noexcept;
 
 private:
   std::string description_;