Disable DLB. (#45568)

Commit Message: Disable DLB due to breakage of contrib build.
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes: included
Fixes #45491

Signed-off-by: Kevin Baichoo <envoy@kevinbaichoo.com>

Author: KBaichoo

api/contrib/envoy/extensions/network/connection_balance/dlb/v3alpha/dlb.proto

@@ -13,6 +13,15 @@ option (udpa.annotations.file_status).package_version_status = ACTIVE;
 // [#protodoc-title: Dlb connection balancer configuration]
 // DLB :ref:`configuration overview <config_connection_balance_dlb>`.
 // [#extension: envoy.network.connection_balance.dlb]
+// [#not-implemented-hide:]
+//
+// The envoy.network.connection_balance.dlb extension is currently disabled
+// at the Bazel layer — see https://github.com/envoyproxy/envoy/issues/45491.
+// The ``[#not-implemented-hide:]`` annotation above suppresses docs
+// generation for this file so protodoc does not try to look the extension
+// up in extensions_metadata.yaml (which has been removed in lockstep with
+// the ``contrib_build_config.bzl`` entry). Drop the annotation when the
+// upstream ``@dlb`` mirror is healthy again.
 
 // The Dlb is a hardware managed system of queues and arbiters connecting producers and consumers. It is a PCIE device
 // in the CPU package. It interacts with software running on cores and potentially other devices. The Dlb implements the

api/envoy/config/listener/v3/listener.proto

@@ -114,7 +114,9 @@ message Listener {
 
       // The listener will use the connection balancer according to ``type_url``. If ``type_url`` is invalid,
       // Envoy will not attempt to balance active connections between worker threads.
-      // [#extension-category: envoy.network.connection_balance]
+      // The ``envoy.network.connection_balance`` extension category is currently empty
+      // because the only registered member (``envoy.network.connection_balance.dlb``)
+      // is disabled. See https://github.com/envoyproxy/envoy/issues/45491.
       core.v3.TypedExtensionConfig extend_balance = 2;
     }
   }

changelogs/current/behavior_changes/build__disable_dlb.rst

@@ -0,0 +1,5 @@
+The contrib extension ``envoy.network.connection_balance.dlb`` (Intel DLB
+connection balancer) has been disabled at the Bazel layer for all builds and
+platforms due to a breakage at the source archive.
+
+See https://github.com/envoyproxy/envoy/issues/45491 for local workarounds.

contrib/contrib_build_config.bzl

@@ -84,7 +84,11 @@ CONTRIB_EXTENSIONS = {
     # Connection Balance extensions
     #
 
-    "envoy.network.connection_balance.dlb":                     "//contrib/dlb/source:connection_balancer",
+    # Disabled: upstream Intel mirror (downloadmirror.intel.com) returns HTTP
+    # 202 Accepted instead of 200 OK, breaking @dlb external_http_archive
+    # fetches and aborting //contrib/exe:envoy-static. See
+    # https://github.com/envoyproxy/envoy/issues/45491
+    # "envoy.network.connection_balance.dlb":                     "//contrib/dlb/source:connection_balancer",
 
     #
     # Regex engines

contrib/dlb/source/BUILD

@@ -13,13 +13,28 @@ licenses(["notice"])  # Apache 2
 
 envoy_contrib_package()
 
+# The envoy.network.connection_balance.dlb extension is disabled at the
+# Bazel layer because the upstream Intel mirror (downloadmirror.intel.com)
+# serving @dlb returns HTTP 202 Accepted instead of 200 OK, which aborts
+# Bazel external_http_archive fetches and breaks any build of
+# //contrib/exe:envoy-static (and any test under //contrib/dlb/...). See
+# https://github.com/envoyproxy/envoy/issues/45491. The targets below
+# carry tags = ["manual"] so they are excluded from wildcard builds and
+# tests (//contrib/...). The matching registration in
+# //contrib:contrib_build_config.bzl is commented out so envoy-static no
+# longer pulls them in. Drop the "manual" tags (and restore the build
+# config + metadata entries) when the upstream @dlb mirror is healthy
+# again or if that does not occur, we will consider dropping this extension.
 make(
     name = "dlb",
     env = {"DLB_DISABLE_DOMAIN_SERVER": "TRUE"},
     lib_source = "@dlb//:libdlb",
     out_static_libs = ["libdlb.a"],
     postfix_script = "mv libdlb.a $$INSTALLDIR/lib && rm -rf $$INSTALLDIR/include && mkdir -p $$INSTALLDIR/include && cp -L *.h $$INSTALLDIR/include",
-    tags = ["skip_on_windows"],
+    tags = [
+        "manual",
+        "skip_on_windows",
+    ],
     target_compatible_with = envoy_contrib_linux_x86_64_constraints(),
     targets = ["libdlb.a"],
 )
@@ -37,6 +52,7 @@ envoy_cc_contrib_extension(
             "DLB_DISABLED=1",
         ],
     }),
+    tags = ["manual"],
     deps = [
         "//envoy/api:api_interface",
         "//envoy/registry",

contrib/dlb/test/BUILD

@@ -8,13 +8,19 @@ licenses(["notice"])  # Apache 2
 
 envoy_contrib_package()
 
+# Disabled along with the envoy.network.connection_balance.dlb extension —
+# see https://github.com/envoyproxy/envoy/issues/45491 and the matching
+# patch in //contrib:contrib_build_config.bzl. The "manual" tag excludes
+# this test from wildcard builds and tests under //contrib/..., avoiding
+# the broken @dlb fetch. Drop it when the upstream mirror is healthy.
 envoy_cc_test(
     name = "config_test",
     srcs = select({
         "//bazel:linux_x86_64": ["config_test.cc"],
         "//conditions:default": [],
     }),
     rbe_pool = "6gig",
+    tags = ["manual"],
     deps = [
         "//contrib/dlb/source:connection_balancer",
         "//source/common/protobuf:utility_lib",

contrib/extensions_metadata.yaml

@@ -108,11 +108,12 @@ envoy.filters.http.language:
   - envoy.filters.http
   security_posture: requires_trusted_downstream_and_upstream
   status: alpha
-envoy.network.connection_balance.dlb:
-  categories:
-  - envoy.network.connection_balance
-  security_posture: requires_trusted_downstream_and_upstream
-  status: alpha
+# Removed due to #45491.
+# envoy.network.connection_balance.dlb:
+#   categories:
+#   - envoy.network.connection_balance
+#   security_posture: requires_trusted_downstream_and_upstream
+#   status: alpha
 envoy.regex_engines.hyperscan:
   categories:
   - envoy.regex_engines

docs/root/api-v3/config/contrib/contrib.rst

@@ -12,7 +12,6 @@ Contrib extensions
   cryptomb/cryptomb
   hyperscan/matcher
   hyperscan/regex_engine
-  dlb/dlb
   postgres/postgres
   qat/qat
   kae/kae

docs/root/api-v3/config/contrib/dlb/dlb.rst

@@ -6,7 +6,6 @@ Listeners
   :maxdepth: 2
 
   ../config/listener/v3/api_listener.proto
-  ../extensions/network/connection_balance/dlb/v3alpha/dlb.proto
   ../config/listener/v3/listener_components.proto
   ../config/listener/v3/listener.proto
   ../config/listener/v3/quic_config.proto