Skip to content

Commit 523e6d1

Browse files
authored
docs: fix typos and formatting issues (#28757)
Signed-off-by: Peter Jausovec <[email protected]>
1 parent 575d44b commit 523e6d1

30 files changed

+197
-172
lines changed

docs/root/configuration/http/http_filters/_include/aws_credentials.rst

+7-7
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@ The filter uses a few different credentials providers to obtain an AWS access ke
55
It moves through the credentials providers in the order described below, stopping when one of them returns an access key ID and a
66
secret access key (the session token is optional).
77

8-
1. Environment variables. The environment variables AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, and AWS_SESSION_TOKEN are used.
8+
1. Environment variables. The environment variables ``AWS_ACCESS_KEY_ID``, ``AWS_SECRET_ACCESS_KEY``, and ``AWS_SESSION_TOKEN`` are used.
99

10-
2. The AWS credentials file. The environment variables AWS_SHARED_CREDENTIALS_FILE and AWS_PROFILE are respected if they are set, else
11-
the file '~/.aws/credentials' and profile 'default' are used. The fields 'aws_access_key_id', 'aws_secret_access_key', and
12-
'aws_session_token' defined for the profile in the credentials file are used. These credentials are cached for 1 hour.
10+
2. The AWS credentials file. The environment variables ``AWS_SHARED_CREDENTIALS_FILE`` and ``AWS_PROFILE`` are respected if they are set, else
11+
the file ``~/.aws/credentials`` and profile ``default`` are used. The fields ``aws_access_key_id``, ``aws_secret_access_key``, and
12+
``aws_session_token`` defined for the profile in the credentials file are used. These credentials are cached for 1 hour.
1313

14-
3. Either EC2 instance metadata or ECS task metadata. For EC2 instance metadata, the fields 'AccessKeyId', 'SecretAccessKey', and
15-
'Token' are used, and credentials are cached for 1 hour. For ECS task metadata, the fields AccessKeyId', 'SecretAccessKey', and
16-
'Token' are used, and credentials are cached for 1 hour or until they expire (according to the field 'Expiration').
14+
3. Either EC2 instance metadata or ECS task metadata. For EC2 instance metadata, the fields ``AccessKeyId``, ``SecretAccessKey``, and
15+
``Token`` are used, and credentials are cached for 1 hour. For ECS task metadata, the fields ``AccessKeyId``, ``SecretAccessKey``, and
16+
``Token`` are used, and credentials are cached for 1 hour or until they expire (according to the field ``Expiration``).

docs/root/configuration/http/http_filters/aws_lambda_filter.rst

+4-4
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ is set to ``false``, then the HTTP request is transformed to a JSON payload with
3939
- ``headers`` are the HTTP request headers. If multiple headers share the same name, their values are
4040
coalesced into a single comma-separated value.
4141
- ``query_string_parameters`` are the HTTP request query string parameters. If multiple parameters share the same name,
42-
the last one wins. That is, parameters are _not_ coalesced into a single value if they share the same key name.
43-
- ``body`` the body of the HTTP request is base64-encoded by the filter if the ``content-type`` header exists and is _not_ one of the following:
42+
the last one wins. That is, parameters are **not** coalesced into a single value if they share the same key name.
43+
- ``body`` the body of the HTTP request is base64-encoded by the filter if the ``content-type`` header exists and is **not** one of the following:
4444

4545
- text/*
4646
- application/json
@@ -66,7 +66,7 @@ On the other end, the response of the Lambda function must conform to the follow
6666
OK``.
6767
- The ``headers`` are used as the HTTP response headers.
6868
- The ``cookies`` are used as ``Set-Cookie`` response headers. Unlike the request headers, cookies are _not_ part of the
69-
response headers because the ``Set-Cookie`` header cannot contain more than one value per the `RFC`_. Therefore, Each
69+
response headers because the ``Set-Cookie`` header cannot contain more than one value per the `RFC`_. Therefore, each
7070
key/value pair in this JSON array will translate to a single ``Set-Cookie`` header.
7171
- The ``body`` is base64-decoded if it is marked as base64-encoded and sent as the body of the HTTP response.
7272

@@ -200,4 +200,4 @@ comes from the owning HTTP connection manager.
200200
:widths: 1, 1, 2
201201

202202
server_error, Counter, Total requests that returned invalid JSON response (see :ref:`payload_passthrough <envoy_v3_api_msg_extensions.filters.http.aws_lambda.v3.Config>`)
203-
upstream_rq_payload_size, Histogram, Size in bytes of the request after JSON-tranformation (if any).
203+
upstream_rq_payload_size, Histogram, Size in bytes of the request after JSON-transformation (if any).

docs/root/configuration/http/http_filters/aws_request_signing_filter.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ policies to determine if this option is appropriate.
2323

2424
When :ref:`use_unsigned_payload <envoy_v3_api_field_extensions.filters.http.aws_request_signing.v3.AwsRequestSigning.use_unsigned_payload>`
2525
is false (the default), requests which exceed the configured buffer limit will receive a 413 response. See the
26-
ref:`flow control docs <faq_flow_control>` for details.
26+
:ref:`flow control docs <faq_flow_control>` for details.
2727

2828
The :ref:`match_excluded_headers <envoy_v3_api_field_extensions.filters.http.aws_request_signing.v3.AwsRequestSigning.match_excluded_headers>`
2929
option allows excluding certain request headers from being signed. This usually applies to headers that are likely to mutate or

docs/root/configuration/http/http_filters/cache_filter.rst

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,14 @@ For HTTP Requests:
1717

1818
For HTTP Responses:
1919

20-
* HTTP Cache only caches responses with enough data to calculate freshness lifetime as per `RFC7234#calculating.freshness.lifetime <https://httpwg.org/specs/rfc7234.html#calculating.freshness.lifetime>`_.
20+
* HTTP Cache only caches responses with enough data to calculate freshness lifetime as per `RFC7234 <https://httpwg.org/specs/rfc7234.html#calculating.freshness.lifetime>`_.
2121
* HTTP Cache respects ``Cache-Control`` directive from the upstream host. For example, if HTTP response returns status code 200 with ``Cache-Control: max-age=60`` and no ``vary`` header, it will be cached.
2222
* HTTP Cache only caches responses with status codes: 200, 203, 204, 206, 300, 301, 308, 404, 405, 410, 414, 451, 501.
2323

2424
HTTP Cache delegates the actual storage of HTTP responses to implementations of the ``HttpCache`` interface. These implementations can
2525
cover all points on the spectrum of persistence, performance, and distribution, from local RAM caches to globally distributed
2626
persistent caches. They can be fully custom caches, or wrappers/adapters around local or remote open-source or proprietary caches.
27-
Currently the only available cache storage implementation is :ref:`SimpleHTTPCache <envoy_v3_api_msg_extensions.http.cache.simple_http_cache.v3.SimpleHttpCacheConfig>`
27+
Currently the only available cache storage implementation is :ref:`SimpleHTTPCache <envoy_v3_api_msg_extensions.http.cache.simple_http_cache.v3.SimpleHttpCacheConfig>`.
2828

2929
Example configuration
3030
---------------------

docs/root/configuration/http/http_filters/composite_filter.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ instantiated.
3939
Statistics
4040
----------
4141

42-
The composite filter outputs statistics in the <stat_prefix>.composite.* namespace.
42+
The composite filter outputs statistics in the ``<stat_prefix>.composite.*`` namespace.
4343

4444
.. csv-table::
4545
:header: Name, Type, Description

docs/root/configuration/http/http_filters/compressor_filter.rst

+56-41
Original file line numberDiff line numberDiff line change
@@ -55,60 +55,75 @@ An example configuration of the filter may look like the following:
5555
5656
By *default* request compression is disabled, but when enabled it will be *skipped* if:
5757

58-
- A request does not contain a *content-type* value that matches one of the selected
59-
mime-types, which default to *application/javascript*, *application/json*,
60-
*application/xhtml+xml*, *image/svg+xml*, *text/css*, *text/html*, *text/plain*,
61-
*text/xml*.
62-
- *content-length* header is not present in the request.
63-
- A request contains a *content-encoding* header.
64-
- A request contains a *transfer-encoding* header whose value includes a known
58+
- A request does **not** contain a ``content-type`` value that matches one of the selected
59+
mime-types, which default to the following:
60+
61+
- ``application/javascript``
62+
- ``application/json``
63+
- ``application/xhtml+xml``
64+
- ``image/svg+xml``
65+
- ``text/css``
66+
- ``text/html``
67+
- ``text/plain``
68+
- ``text/xml``
69+
70+
- A request does **not** contain a ``content-length`` header.
71+
- A request contains a ``content-encoding`` header.
72+
- A request contains a ``transfer-encoding`` header whose value includes a known
6573
compression name.
6674

6775
By *default* response compression is enabled, but it will be *skipped* when:
6876

69-
- A request does NOT contain *accept-encoding* header.
70-
- A request includes *accept-encoding* header, but it does not contain "gzip" or "\*".
71-
- A request includes *accept-encoding* with "gzip" or "\*" with the weight "q=0". Note
72-
that the "gzip" will have a higher weight then "\*". For example, if *accept-encoding*
73-
is "gzip;q=0,\*;q=1", the filter will not compress. But if the header is set to
74-
"\*;q=0,gzip;q=1", the filter will compress.
75-
- A request whose *accept-encoding* header includes any encoding type with a higher
76-
weight than "gzip"'s given the corresponding compression filter is present in the chain.
77-
- A response contains a *content-encoding* header.
78-
- A response contains a *cache-control* header whose value includes "no-transform".
79-
- A response contains a *transfer-encoding* header whose value includes a known
77+
- A request does **not** contain ``accept-encoding`` header.
78+
- A request contains an ``accept-encoding`` header, but it does not contain ``gzip`` or ``\*``.
79+
- A request contains an ``accept-encoding`` header with ``gzip`` or ``\*```` with the weight ``q=0``. Note
80+
that the ``gzip`` will have a higher weight than ``\*``. For example, if ``accept-encoding``
81+
is ``gzip;q=0,\*;q=1``, the filter will not compress. But if the header is set to
82+
``\*;q=0,gzip;q=1``, the filter will compress.
83+
- A request whose ``accept-encoding`` header includes any encoding type with a higher
84+
weight than ``gzip``'s given the corresponding compression filter is present in the chain.
85+
- A response contains a ``content-encoding`` header.
86+
- A response contains a ``cache-control```` header whose value includes ``no-transform``.
87+
- A response contains a ``transfer-encoding```` header whose value includes a known
8088
compression name.
81-
- A response does not contain a *content-type* value that matches one of the selected
82-
mime-types, which default to *application/javascript*, *application/json*,
83-
*application/xhtml+xml*, *image/svg+xml*, *text/css*, *text/html*, *text/plain*,
84-
*text/xml*.
85-
- Neither *content-length* nor *transfer-encoding* headers are present in
86-
the response.
87-
- Response size is smaller than 30 bytes (only applicable when *transfer-encoding*
89+
- A response does **not** contain a ``content-type`` value that matches one of the selected
90+
mime-types, which default to:
91+
92+
- ``application/javascript``
93+
- ``application/json``
94+
- ``application/xhtml+xml``
95+
- ``image/svg+xml``
96+
- ``text/css``
97+
- ``text/html``
98+
- ``text/plain``
99+
- ``text/xml``
100+
101+
- A response does **not** contain a ``content-length`` or ``transfer-encoding`` headers.
102+
- Response size is smaller than 30 bytes (only applicable when ``transfer-encoding``
88103
is not chunked).
89104

90105
Please note that in case the filter is configured to use a compression library extension
91-
other than gzip it looks for content encoding in the *accept-encoding* header provided by
106+
other than gzip it looks for content encoding in the ``accept-encoding`` header provided by
92107
the extension.
93108

94109
When response compression is *applied*:
95110

96-
- The *content-length* is removed from response headers.
97-
- Response headers contain "*transfer-encoding: chunked*", and
98-
"*content-encoding*" with the compression scheme used (e.g., ``gzip``).
99-
- The "*vary: accept-encoding*" header is inserted on every response.
111+
- The ``content-length`` is removed from response headers.
112+
- Response headers contain ``transfer-encoding: chunked``, and
113+
``content-encoding`` with the compression scheme used (e.g., ``gzip``).
114+
- The ``vary: accept-encoding`` header is inserted on every response.
100115

101-
Also the "*vary: accept-encoding*" header may be inserted even if compression is *not*
102-
applied due to incompatible "*accept-encoding*" header in a request. This happens
103-
when the requested resource still can be compressed given compatible "*accept-encoding*".
116+
Also the ``vary: accept-encoding`` header may be inserted even if compression is **not**
117+
applied due to incompatible ``accept-encoding`` header in a request. This happens
118+
when the requested resource can still be compressed given compatible ``accept-encoding``.
104119
Otherwise, if an uncompressed response is cached by a caching proxy in front of Envoy,
105-
the proxy won't know to fetch a new incoming request with compatible "*accept-encoding*"
120+
the proxy won't know to fetch a new incoming request with compatible ``accept-encoding``
106121
from upstream.
107122

108123
When request compression is *applied*:
109124

110-
- *content-length* is removed from request headers.
111-
- *content-encoding* with the compression scheme used (e.g., ``gzip``) is added to
125+
- ``content-length`` is removed from request headers.
126+
- ``content-encoding`` with the compression scheme used (e.g., ``gzip``) is added to
112127
request headers.
113128

114129
Per-Route Configuration
@@ -215,12 +230,12 @@ specific to responses only:
215230
:widths: 1, 1, 2
216231

217232
no_accept_header, Counter, Number of requests with no accept header sent.
218-
header_identity, Counter, Number of requests sent with "identity" set as the *accept-encoding*.
219-
header_compressor_used, Counter, Number of requests sent with filter's configured encoding set as the *accept-encoding*.
233+
header_identity, Counter, Number of requests sent with "identity" set as the ``accept-encoding``.
234+
header_compressor_used, Counter, Number of requests sent with filter's configured encoding set as the ``accept-encoding``.
220235
header_compressor_overshadowed, Counter, Number of requests skipped by this filter instance because they were handled by another filter in the same filter chain.
221-
header_wildcard, Counter, Number of requests sent with "\*" set as the *accept-encoding*.
222-
header_not_valid, Counter, Number of requests sent with a not valid *accept-encoding* header (aka "q=0" or an unsupported encoding type).
223-
not_compressed_etag, Counter, Number of requests that were not compressed due to the etag header. *disable_on_etag_header* must be turned on for this to happen.
236+
header_wildcard, Counter, Number of requests sent with ``\*`` set as the ``accept-encoding``.
237+
header_not_valid, Counter, Number of requests sent with a not valid ``accept-encoding`` header (aka ``q=0`` or an unsupported encoding type).
238+
not_compressed_etag, Counter, Number of requests that were not compressed due to the etag header. ``disable_on_etag_header`` must be turned on for this to happen.
224239

225240
.. attention:
226241

docs/root/configuration/http/http_filters/connect_grpc_bridge_filter.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ Connect-gRPC Bridge
88
* :ref:`v3 API reference <envoy_v3_api_msg_extensions.filters.http.connect_grpc_bridge.v3.FilterConfig>`
99

1010
This filter enables a Buf Connect client to connect to a compliant gRPC server.
11-
More information on the Buf Connect protocol can be found here https://connect.build/docs/protocol.
11+
More information on the Buf Connect protocol can be found `here <https://connect.build/docs/protocol>`_.
1212

1313
HTTP GET support
1414
----------------

docs/root/configuration/http/http_filters/cors_filter.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ will not enforce any policies.
4545
Statistics
4646
----------
4747

48-
The CORS filter outputs statistics in the <stat_prefix>.cors.* namespace.
48+
The CORS filter outputs statistics in the ``<stat_prefix>.cors.*`` namespace.
4949

5050
.. note::
5151
Requests that do not have an Origin header will be omitted from statistics.

docs/root/configuration/http/http_filters/csrf_filter.rst

+5-4
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,8 @@ There are many ways to mitigate CSRF, some of which have been outlined in the
2020
This filter employs a stateless mitigation pattern known as origin verification.
2121

2222
This pattern relies on two pieces of information used in determining if
23-
a request originated from the same host.
23+
a request originated from the same host:
24+
2425
* The origin that caused the user agent to issue the request (source origin).
2526
* The origin that the request is going to (target origin).
2627

@@ -39,7 +40,7 @@ requests, the filter only acts on HTTP requests that have a state-changing metho
3940

4041
For more information on CSRF please refer to the pages below.
4142

42-
* https://www.owasp.org/index.php/Cross-Site_Request_Forgery_%28CSRF%29
43+
* https://owasp.org/www-community/attacks/csrf
4344
* https://seclab.stanford.edu/websec/csrf/csrf.pdf
4445
* This filter should be configured with the type URL ``type.googleapis.com/envoy.extensions.filters.http.csrf.v3.CsrfPolicy``.
4546
* :ref:`v3 API reference <envoy_v3_api_msg_extensions.filters.http.csrf.v3.CsrfPolicy>`
@@ -52,7 +53,7 @@ Configuration
5253
The CSRF filter supports the ability to extend the source origins it will consider
5354
valid. The reason it is able to do this while still mitigating cross-site request
5455
forgery attempts is because the target origin has already been reached by the time
55-
front-envoy is applying the filter. This means that while endpoints may support
56+
front Envoy is applying the filter. This means that while endpoints may support
5657
cross-origin requests they are still protected from malicious third-parties who
5758
have not been allowlisted.
5859

@@ -92,7 +93,7 @@ to determine if it's valid but will not enforce any policies.
9293
Statistics
9394
----------
9495

95-
The CSRF filter outputs statistics in the <stat_prefix>.csrf.* namespace.
96+
The CSRF filter outputs statistics in the ``<stat_prefix>.csrf.`` namespace.
9697

9798
.. csv-table::
9899
:header: Name, Type, Description

docs/root/configuration/http/http_filters/decompressor_filter.rst

+12-12
Original file line numberDiff line numberDiff line change
@@ -37,27 +37,27 @@ An example configuration of the filter may look like the following:
3737
3838
By *default* decompression will be *skipped* when:
3939

40-
- A request/response does NOT contain *content-encoding* header.
41-
- A request/response includes *content-encoding* header, but it does not contain the configured
42-
decompressor's content-encoding.
43-
- A request/response contains a *cache-control* header whose value includes "no-transform",
40+
- A request/response does **not** contain ``content-encoding`` header.
41+
- A request/response contains a ``content-encoding`` header, but it does not contain the configured
42+
decompressor's ``content-encoding``.
43+
- A request/response contains a ``cache-control`` header whose value includes ``no-transform``,
4444
unless :ref:`ignore_no_transform_header <envoy_v3_api_field_extensions.filters.http.decompressor.v3.Decompressor.CommonDirectionConfig.ignore_no_transform_header>`
45-
is set to *true*.
45+
is set to ``true``.
4646

47-
When decompression is *applied*:
47+
Decompression is *applied* when:
4848

49-
- The *content-length* is removed from headers.
49+
- The ``content-length`` is removed from headers.
5050

5151
.. note::
5252

53-
If an updated *content-length* header is desired, the buffer filter can be installed as part
53+
If an updated ``content-length`` header is desired, the :ref: `buffer filter <_config_http_filters_buffer>` can be installed as part
5454
of the filter chain to buffer decompressed frames, and ultimately update the header. Due to
5555
:ref:`filter ordering <arch_overview_http_filters_ordering>` a buffer filter needs to be
5656
installed after the decompressor for requests and prior to the decompressor for responses.
5757

58-
- The *content-encoding* header is modified to remove the decompression that was applied.
58+
- The ``content-encoding`` header is modified to remove the decompression that was applied.
5959

60-
- *x-envoy-decompressor-<decompressor_name>-<compressed/uncompressed>-bytes* trailers are added to
60+
- ``x-envoy-decompressor-<decompressor_name>-<compressed/uncompressed>-bytes`` trailers are added to
6161
the request/response to relay information about decompression.
6262

6363
Using different decompressors for requests and responses
@@ -106,7 +106,7 @@ Statistics
106106
----------
107107

108108
Every configured Deompressor filter has statistics rooted at
109-
<stat_prefix>.decompressor.<decompressor_library.name>.<decompressor_library_stat_prefix>.<request/response>*
109+
``<stat_prefix>.decompressor.<decompressor_library.name>.<decompressor_library_stat_prefix>.<request/response>*``
110110
with the following:
111111

112112
.. csv-table::
@@ -119,4 +119,4 @@ with the following:
119119
total_compressed_bytes, Counter, The total compressed bytes of all the request/responses that were marked for decompression.
120120

121121
Additional stats for the decompressor library are rooted at
122-
<stat_prefix>.decompressor.<decompressor_library.name>.<decompressor_library_stat_prefix>.decompressor_library.
122+
``<stat_prefix>.decompressor.<decompressor_library.name>.<decompressor_library_stat_prefix>.decompressor_library``.

0 commit comments

Comments
 (0)