Skip to content

Commit e0420ee

Browse files
authored
Switch coverage CI targets to EngFlow (#39269)
Commit Message: Currently Envoy CI uses different RBE backends for different CI targets. EngFlow is one of available backends and we want to migrate most if not all targets to EngFlow. Other than just making the overall CI setup simpler, EngFlow appear to offer more powerful build grid machines at the moment, plus some additional nice features like automatically scaling memory when build tasks don't fit into available memory. One specific reason why I'd like to migrate coverage targets to EngFlow is because I want to switch them to static linking to workaround a bug in Clang/LLVM source-based coverage (see llvm/llvm-project#32849). With currently used Google RBE backend we are having issues with fuzzing coverage tests, as fuzzing tests include a lot of extensions and together with coverage instrumentation it pushes linker memory footrpint way to high and causing OOMs. Our approach to solving this particular problem is two-fold: 1. I want to migrate to EngFlow that can offer bigger machines (and it aligns with the general direction for Envoy CI to migrate to EngFlow. 2. I want to optimize our fuzzing targets a little bit by cutting out some unnecessary bits and reducing the number of libraries that linker need to link together (on top of reducing the amount of time it takes to build things and similar benefits). This particular PR takes care of the first part. Additional Description: Some relevant discussions can be found in #39030 which prompted me to work on this in the first place. And I will use #39248 as a tracking bug for the coverage changes. Risk Level: medium (it could break CI and cause disruption, but rolling it back should be easy) Testing: I applied the same change in the envoy-ci-staging repo and created a test PR to see if EngFlow is used for coverage. The setup between envoy-ci-staging and envoy repo is not exactly the same, so I could have missed something. --------- Signed-off-by: Mikhail Krinkin <[email protected]>
1 parent d7bf028 commit e0420ee

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

.github/workflows/_check_coverage.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
uses: ./.github/workflows/_run.yml
3939
name: ${{ matrix.name ||matrix.target }}
4040
with:
41-
# bazel-extra: '--config=remote-envoy-engflow'
41+
bazel-extra: '--config=remote-envoy-engflow'
4242
cache-build-image: ${{ fromJSON(inputs.request).request.build-image.default }}
4343
concurrency-suffix: -${{ matrix.target }}
4444
diskspace-hack: ${{ matrix.diskspace-hack && true || false }}
@@ -50,7 +50,6 @@ jobs:
5050
lower than limit
5151
gcs-cache-bucket: ${{ inputs.gcs-cache-bucket }}
5252
rbe: true
53-
rbe-google: true
5453
request: ${{ inputs.request }}
5554
runs-on: ${{ fromJSON(inputs.request).config.ci.agent-ubuntu }}
5655
steps-post: |

0 commit comments

Comments
 (0)