dynamic_modules: add numeric and bool access logger metadata getters (#45628)

Author: agrawroh

source/extensions/access_loggers/dynamic_modules/abi_impl.cc

@@ -741,6 +741,23 @@ bool envoy_dynamic_module_callback_access_logger_get_dynamic_metadata(
   return ContextAccessor::getDynamicMetadata(*logger->stream_info_, filter_name, path, result);
 }
 
+bool envoy_dynamic_module_callback_access_logger_get_dynamic_metadata_number(
+    envoy_dynamic_module_type_access_logger_envoy_ptr logger_envoy_ptr,
+    envoy_dynamic_module_type_module_buffer filter_name,
+    envoy_dynamic_module_type_module_buffer path, double* result) {
+  auto* logger = static_cast<ThreadLocalLogger*>(logger_envoy_ptr);
+  return ContextAccessor::getDynamicMetadataNumber(*logger->stream_info_, filter_name, path,
+                                                   result);
+}
+
+bool envoy_dynamic_module_callback_access_logger_get_dynamic_metadata_bool(
+    envoy_dynamic_module_type_access_logger_envoy_ptr logger_envoy_ptr,
+    envoy_dynamic_module_type_module_buffer filter_name,
+    envoy_dynamic_module_type_module_buffer path, bool* result) {
+  auto* logger = static_cast<ThreadLocalLogger*>(logger_envoy_ptr);
+  return ContextAccessor::getDynamicMetadataBool(*logger->stream_info_, filter_name, path, result);
+}
+
 bool envoy_dynamic_module_callback_access_logger_get_filter_state(
     envoy_dynamic_module_type_access_logger_envoy_ptr logger_envoy_ptr,
     envoy_dynamic_module_type_module_buffer key, envoy_dynamic_module_type_envoy_buffer* result) {

source/extensions/dynamic_modules/abi/abi.h

@@ -7000,6 +7000,34 @@ bool envoy_dynamic_module_callback_access_logger_get_dynamic_metadata(
     envoy_dynamic_module_type_module_buffer filter_name,
     envoy_dynamic_module_type_module_buffer path, envoy_dynamic_module_type_envoy_buffer* result);
 
+/**
+ * Get a number value from dynamic metadata by filter name and key path.
+ *
+ * @param logger_envoy_ptr is the pointer to the log context.
+ * @param filter_name is the filter namespace in dynamic metadata.
+ * @param path is the key path within the filter namespace (can be nested with dots).
+ * @param result receives the number value. Only number-typed metadata is returned.
+ * @return true if a number value exists at the path, false otherwise.
+ */
+bool envoy_dynamic_module_callback_access_logger_get_dynamic_metadata_number(
+    envoy_dynamic_module_type_access_logger_envoy_ptr logger_envoy_ptr,
+    envoy_dynamic_module_type_module_buffer filter_name,
+    envoy_dynamic_module_type_module_buffer path, double* result);
+
+/**
+ * Get a bool value from dynamic metadata by filter name and key path.
+ *
+ * @param logger_envoy_ptr is the pointer to the log context.
+ * @param filter_name is the filter namespace in dynamic metadata.
+ * @param path is the key path within the filter namespace (can be nested with dots).
+ * @param result receives the bool value. Only bool-typed metadata is returned.
+ * @return true if a bool value exists at the path, false otherwise.
+ */
+bool envoy_dynamic_module_callback_access_logger_get_dynamic_metadata_bool(
+    envoy_dynamic_module_type_access_logger_envoy_ptr logger_envoy_ptr,
+    envoy_dynamic_module_type_module_buffer filter_name,
+    envoy_dynamic_module_type_module_buffer path, bool* result);
+
 /**
  * Get a value from filter state by key.
  *

source/extensions/dynamic_modules/abi_context_accessors.cc

@@ -55,6 +55,18 @@ bool getUpstreamSslAttribute(
   return true;
 }
 
+// Resolve a dynamic metadata value by filter name and dotted key path. Returns an unset value
+// when the path is absent.
+const Protobuf::Value& dynamicMetadataValue(const StreamInfo::StreamInfo& stream_info,
+                                            envoy_dynamic_module_type_module_buffer filter_name,
+                                            envoy_dynamic_module_type_module_buffer path) {
+  std::string filter_name_str(filter_name.ptr, filter_name.length);
+  std::string path_str(path.ptr, path.length);
+  std::vector<std::string> path_parts = absl::StrSplit(path_str, '.');
+  const auto& metadata = stream_info.dynamicMetadata();
+  return Envoy::Config::Metadata::metadataValue(&metadata, filter_name_str, path_parts);
+}
+
 } // namespace
 
 HeadersMapOptConstRef
@@ -474,26 +486,37 @@ bool ContextAccessor::getDynamicMetadata(const StreamInfo::StreamInfo& stream_in
                                          envoy_dynamic_module_type_module_buffer filter_name,
                                          envoy_dynamic_module_type_module_buffer path,
                                          envoy_dynamic_module_type_envoy_buffer* result) {
-  std::string filter_name_str(filter_name.ptr, filter_name.length);
-  std::string path_str(path.ptr, path.length);
-  std::vector<std::string> path_parts = absl::StrSplit(path_str, '.');
-
-  const auto& metadata = stream_info.dynamicMetadata();
-  const auto& value =
-      Envoy::Config::Metadata::metadataValue(&metadata, filter_name_str, path_parts);
-
-  if (value.kind_case() == Protobuf::Value::KIND_NOT_SET) {
-    return false;
-  }
-
-  // Note: Currently only string values are supported. Complex types would require serialization
-  // to a buffer, but the ABI uses zero-copy pointers to Envoy memory.
+  // String values are returned zero-copy here. Numbers and bools have dedicated typed accessors.
+  const auto& value = dynamicMetadataValue(stream_info, filter_name, path);
   if (value.kind_case() == Protobuf::Value::kStringValue) {
     const auto& str = value.string_value();
     *result = {const_cast<char*>(str.data()), str.size()};
     return true;
   }
+  return false;
+}
+
+bool ContextAccessor::getDynamicMetadataNumber(const StreamInfo::StreamInfo& stream_info,
+                                               envoy_dynamic_module_type_module_buffer filter_name,
+                                               envoy_dynamic_module_type_module_buffer path,
+                                               double* result) {
+  const auto& value = dynamicMetadataValue(stream_info, filter_name, path);
+  if (value.kind_case() == Protobuf::Value::kNumberValue) {
+    *result = value.number_value();
+    return true;
+  }
+  return false;
+}
 
+bool ContextAccessor::getDynamicMetadataBool(const StreamInfo::StreamInfo& stream_info,
+                                             envoy_dynamic_module_type_module_buffer filter_name,
+                                             envoy_dynamic_module_type_module_buffer path,
+                                             bool* result) {
+  const auto& value = dynamicMetadataValue(stream_info, filter_name, path);
+  if (value.kind_case() == Protobuf::Value::kBoolValue) {
+    *result = value.bool_value();
+    return true;
+  }
   return false;
 }
 

source/extensions/dynamic_modules/abi_context_accessors.h

@@ -57,13 +57,26 @@ class ContextAccessor {
   static bool getAttributeBool(const StreamInfo::StreamInfo& stream_info,
                                envoy_dynamic_module_type_attribute_id attribute_id, bool* result);
 
-  // Get a value from dynamic metadata by filter name and dotted key path. Only string values are
-  // returned, matching the zero-copy ABI contract.
+  // Get a string value from dynamic metadata by filter name and dotted key path. Returns false
+  // when the path is absent or the value is not a string.
   static bool getDynamicMetadata(const StreamInfo::StreamInfo& stream_info,
                                  envoy_dynamic_module_type_module_buffer filter_name,
                                  envoy_dynamic_module_type_module_buffer path,
                                  envoy_dynamic_module_type_envoy_buffer* result);
 
+  // Get a number value from dynamic metadata by filter name and dotted key path. Returns false
+  // when the path is absent or the value is not a number.
+  static bool getDynamicMetadataNumber(const StreamInfo::StreamInfo& stream_info,
+                                       envoy_dynamic_module_type_module_buffer filter_name,
+                                       envoy_dynamic_module_type_module_buffer path,
+                                       double* result);
+
+  // Get a bool value from dynamic metadata by filter name and dotted key path. Returns false when
+  // the path is absent or the value is not a bool.
+  static bool getDynamicMetadataBool(const StreamInfo::StreamInfo& stream_info,
+                                     envoy_dynamic_module_type_module_buffer filter_name,
+                                     envoy_dynamic_module_type_module_buffer path, bool* result);
+
   // Get the local reply body from the formatting context. Returns false when there is no body.
   static bool getLocalReplyBody(const Formatter::Context& context,
                                 envoy_dynamic_module_type_envoy_buffer* result);

source/extensions/dynamic_modules/abi_impl.cc

@@ -2237,6 +2237,22 @@ __attribute__((weak)) bool envoy_dynamic_module_callback_access_logger_get_dynam
   return false;
 }
 
+__attribute__((weak)) bool envoy_dynamic_module_callback_access_logger_get_dynamic_metadata_number(
+    envoy_dynamic_module_type_access_logger_envoy_ptr, envoy_dynamic_module_type_module_buffer,
+    envoy_dynamic_module_type_module_buffer, double*) {
+  IS_ENVOY_BUG("envoy_dynamic_module_callback_access_logger_get_dynamic_metadata_number: not "
+               "implemented in this context");
+  return false;
+}
+
+__attribute__((weak)) bool envoy_dynamic_module_callback_access_logger_get_dynamic_metadata_bool(
+    envoy_dynamic_module_type_access_logger_envoy_ptr, envoy_dynamic_module_type_module_buffer,
+    envoy_dynamic_module_type_module_buffer, bool*) {
+  IS_ENVOY_BUG("envoy_dynamic_module_callback_access_logger_get_dynamic_metadata_bool: not "
+               "implemented in this context");
+  return false;
+}
+
 __attribute__((weak)) bool envoy_dynamic_module_callback_access_logger_get_filter_state(
     envoy_dynamic_module_type_access_logger_envoy_ptr, envoy_dynamic_module_type_module_buffer,
     envoy_dynamic_module_type_envoy_buffer*) {

source/extensions/dynamic_modules/sdk/rust/src/access_log.rs

@@ -636,8 +636,10 @@ impl LogContext {
   /// * `key` - The key within the filter namespace (e.g., "rbac_policy").
   ///
   /// # Returns
-  /// The string value if it exists, None otherwise.
-  /// Note: Only string values are currently supported.
+  /// The string value if it exists and is string-typed, None otherwise. Use
+  /// [`get_dynamic_metadata_number`](Self::get_dynamic_metadata_number) or
+  /// [`get_dynamic_metadata_bool`](Self::get_dynamic_metadata_bool) for number- and bool-typed
+  /// values.
   pub fn get_dynamic_metadata(&self, filter_name: &str, key: &str) -> Option<EnvoyBuffer<'_>> {
     let filter_buf = abi::envoy_dynamic_module_type_module_buffer {
       ptr: filter_name.as_ptr() as *const _,
@@ -665,6 +667,70 @@ impl LogContext {
     }
   }
 
+  /// Get a number value from dynamic metadata.
+  ///
+  /// # Arguments
+  /// * `filter_name` - The filter namespace (e.g., "envoy.filters.http.dynamic_module").
+  /// * `key` - The key within the filter namespace (e.g., "handshake_state").
+  ///
+  /// # Returns
+  /// The number value if it exists and is number-typed, None otherwise.
+  pub fn get_dynamic_metadata_number(&self, filter_name: &str, key: &str) -> Option<f64> {
+    let filter_buf = abi::envoy_dynamic_module_type_module_buffer {
+      ptr: filter_name.as_ptr() as *const _,
+      length: filter_name.len(),
+    };
+    let key_buf = abi::envoy_dynamic_module_type_module_buffer {
+      ptr: key.as_ptr() as *const _,
+      length: key.len(),
+    };
+    let mut result: f64 = 0.0;
+    if unsafe {
+      abi::envoy_dynamic_module_callback_access_logger_get_dynamic_metadata_number(
+        self.envoy_ptr,
+        filter_buf,
+        key_buf,
+        &mut result,
+      )
+    } {
+      Some(result)
+    } else {
+      None
+    }
+  }
+
+  /// Get a bool value from dynamic metadata.
+  ///
+  /// # Arguments
+  /// * `filter_name` - The filter namespace (e.g., "envoy.filters.http.dynamic_module").
+  /// * `key` - The key within the filter namespace (e.g., "tls_enabled").
+  ///
+  /// # Returns
+  /// The bool value if it exists and is bool-typed, None otherwise.
+  pub fn get_dynamic_metadata_bool(&self, filter_name: &str, key: &str) -> Option<bool> {
+    let filter_buf = abi::envoy_dynamic_module_type_module_buffer {
+      ptr: filter_name.as_ptr() as *const _,
+      length: filter_name.len(),
+    };
+    let key_buf = abi::envoy_dynamic_module_type_module_buffer {
+      ptr: key.as_ptr() as *const _,
+      length: key.len(),
+    };
+    let mut result: bool = false;
+    if unsafe {
+      abi::envoy_dynamic_module_callback_access_logger_get_dynamic_metadata_bool(
+        self.envoy_ptr,
+        filter_buf,
+        key_buf,
+        &mut result,
+      )
+    } {
+      Some(result)
+    } else {
+      None
+    }
+  }
+
   /// Get the local reply body (if this was a local response).
   pub fn local_reply_body(&self) -> Option<EnvoyBuffer<'_>> {
     self.get_envoy_buffer(abi::envoy_dynamic_module_callback_access_logger_get_local_reply_body)