deps: bump googletest to v1.17.0 without regex and memory pool changes

Signed-off-by: Rohit Agrawal <[email protected]>

Author: agrawroh

test/common/http/header_mutation_test.cc

@@ -276,7 +276,7 @@ TEST(HeaderMutationTest, Death) {
   ProtoHeaderMutatons proto_mutations;
   proto_mutations.Add();
 
-  EXPECT_DEATH(HeaderMutations::create(proto_mutations).IgnoreError(), ".*unset oneof.*");
+  EXPECT_DEATH(HeaderMutations::create(proto_mutations).IgnoreError(), "unset oneof");
 }
 
 } // namespace

test/common/quic/envoy_quic_proof_verifier_test.cc

@@ -446,7 +446,7 @@ TEST_F(EnvoyQuicProofVerifierTest, VerifyProof) {
   configCertVerificationDetails(true);
   EXPECT_DEATH(verifier_->VerifyProof("", 0, "", quic::QUIC_VERSION_IETF_RFC_V1, "", {}, "", "",
                                       nullptr, nullptr, nullptr, {}),
-               ".*not implemented.*");
+               "not implemented");
 }
 
 TEST_F(EnvoyQuicProofVerifierTest, CreateDefaultContext) {

test/common/quic/quic_filter_manager_connection_impl_test.cc

@@ -114,7 +114,7 @@ TEST_F(QuicFilterManagerConnectionImplTest, RawWrite) {
 }
 
 TEST_F(QuicFilterManagerConnectionImplTest, BufferLimit) {
-  EXPECT_DEATH(impl_.bufferLimit(), ".*not implemented.*");
+  EXPECT_DEATH(impl_.bufferLimit(), "not implemented");
 }
 
 TEST_F(QuicFilterManagerConnectionImplTest, SetBufferLimits) {
@@ -127,11 +127,12 @@ TEST_F(QuicFilterManagerConnectionImplTest, CloseConnection) {
 }
 
 TEST_F(QuicFilterManagerConnectionImplTest, GetWriteBuffer) {
-  EXPECT_DEATH(impl_.getWriteBuffer(), ".*not implemented.*");
+  EXPECT_DEATH(impl_.getWriteBuffer(), "not implemented");
 }
 
 TEST_F(QuicFilterManagerConnectionImplTest, EnableHalfClose) {
-  EXPECT_DEATH(impl_.enableHalfClose(true), ".*Quic connection doesn't support half close.*");
+  impl_.enableHalfClose(false); // No-op
+  EXPECT_DEATH(impl_.enableHalfClose(true), "Quic connection doesn't support half close.");
 }
 
 TEST_F(QuicFilterManagerConnectionImplTest, IsHalfCloseEnabled) {

test/extensions/filters/http/kill_request/kill_request_filter_test.cc

@@ -47,7 +47,7 @@ TEST_F(KillRequestFilterTest, KillRequestCrashEnvoy) {
 
   ON_CALL(random_generator_, random()).WillByDefault(Return(0));
   EXPECT_DEATH(filter_->decodeHeaders(request_headers_, false),
-               ".*KillRequestFilter is crashing Envoy!!!.*");
+               "KillRequestFilter is crashing Envoy!!!");
 }
 
 TEST_F(KillRequestFilterTest, KillRequestCrashEnvoyWithCustomKillHeader) {
@@ -59,15 +59,15 @@ TEST_F(KillRequestFilterTest, KillRequestCrashEnvoyWithCustomKillHeader) {
 
   ON_CALL(random_generator_, random()).WillByDefault(Return(0));
   EXPECT_DEATH(filter_->decodeHeaders(request_headers_, false),
-               ".*KillRequestFilter is crashing Envoy!!!.*");
+               "KillRequestFilter is crashing Envoy!!!");
 }
 
 TEST_F(KillRequestFilterTest, KillRequestWithMillionDenominatorCrashEnvoy) {
   envoy::extensions::filters::http::kill_request::v3::KillRequest kill_request;
   kill_request.mutable_probability()->set_numerator(1);
   kill_request.mutable_probability()->set_denominator(envoy::type::v3::FractionalPercent::MILLION);
   setUpTest(kill_request);
-  request_headers_.addCopy("x-envoy-kill-request", "yes");
+  request_headers_.addCopy("x-envoy-kill-request", "true");
 
   ON_CALL(random_generator_, random()).WillByDefault(Return(0));
   EXPECT_DEATH(filter_->decodeHeaders(request_headers_, false),
@@ -183,7 +183,7 @@ TEST_F(KillRequestFilterTest, CanKillOnResponse) {
   ON_CALL(random_generator_, random()).WillByDefault(Return(0));
   response_headers_.addCopy("x-envoy-kill-request", "true");
   EXPECT_DEATH(filter_->encodeHeaders(response_headers_, false),
-               ".*KillRequestFilter is crashing Envoy!!!.*");
+               "KillRequestFilter is crashing Envoy!!!");
 }
 
 TEST_F(KillRequestFilterTest, KillsBasedOnDirection) {
@@ -201,7 +201,7 @@ TEST_F(KillRequestFilterTest, KillsBasedOnDirection) {
   ON_CALL(random_generator_, random()).WillByDefault(Return(0));
   response_headers_.addCopy("x-envoy-kill-request", "true");
   EXPECT_DEATH(filter_->encodeHeaders(response_headers_, false),
-               ".*KillRequestFilter is crashing Envoy!!!.*");
+               "KillRequestFilter is crashing Envoy!!!");
 }
 
 TEST_F(KillRequestFilterTest, PerRouteKillSettingFound) {

test/extensions/matching/input_matchers/cel_matcher/cel_matcher_test.cc

@@ -562,7 +562,7 @@ TEST_F(CelMatcherTest, CelMatcherRequestResponseNotMatchedWithParsedExprUseCel)
 
 TEST_F(CelMatcherTest, NoCelExpression) {
   EXPECT_DEATH(buildMatcherTree(RequestHeaderCelExprString, ExpressionType::NoExpression),
-               ".*unset oneof.*");
+               ".*panic: unset oneof.*");
 }
 
 } // namespace CelMatcher

test/integration/BUILD

@@ -1142,7 +1142,7 @@ envoy_cc_test_library(
     hdrs = [
         "fake_upstream.h",
     ],
-    rbe_pool = "12gig",  # Increased from 6gig to prevent OOM kills during compilation
+    rbe_pool = "6gig",
     deps = [
         ":utility_lib",
         "//envoy/api:api_interface",
@@ -1222,7 +1222,7 @@ envoy_cc_test_library(
     hdrs = [
         "base_integration_test.h",
     ],
-    rbe_pool = "12gig",  # Increased from 6gig to prevent OOM kills during compilation
+    rbe_pool = "6gig",
     deps = [
         ":async_round_robin_lb",
         ":autonomous_upstream_lib",
@@ -1267,7 +1267,7 @@ envoy_cc_test_library(
     hdrs = [
         "autonomous_upstream.h",
     ],
-    rbe_pool = "12gig",  # Increased from 6gig to prevent OOM kills during compilation
+    rbe_pool = "6gig",
     deps = [
         ":fake_upstream_lib",
     ],

test/server/guarddog_impl_test.cc

@@ -89,14 +89,11 @@ INSTANTIATE_TEST_SUITE_P(TimeSystemType, GuardDogTestBase,
 class GuardDogDeathTest : public GuardDogTestBase {
 protected:
   GuardDogDeathTest()
-      : config_kill_(1000, 1000, 100, 1000, 0, std::vector<std::string>{}),
+      : config_kill_(1000, 1000, 1000, 1000, 0, std::vector<std::string>{}),
         config_multikill_(1000, 1000, 1000, 500, 0, std::vector<std::string>{}),
         config_multikill_threshold_(1000, 1000, 1000, 500, 60, std::vector<std::string>{}) {}
 
-  void SetUp() override {
-    GTEST_FLAG_SET(death_test_style, "threadsafe");
-    GuardDogTestBase::SetUp();
-  }
+  void SetUp() override { GuardDogTestBase::SetUp(); }
 
   /**
    * This does everything but the final forceCheckForTest() that should cause

test/test_listener.cc

@@ -28,16 +28,15 @@ void TestListener::OnTestEnd(const ::testing::TestInfo& test_info) {
                                   test_info.name(), "] test exited before main thread shut down"));
   }
 
-  // Save death_test_style flag value before resetting flags
-  std::string death_test_style = ::absl::GetFlag(FLAGS_gtest_death_test_style);
-
   // We must do this in two phases; reset the old flags to get back to the clean state before
   // constructing a new flag saver to latch the clean values.
   saver_.reset();
   saver_ = std::make_unique<::absl::FlagSaver>();
 
-  // Restore the death_test_style flag to its previous value
-  ::absl::SetFlag(&FLAGS_gtest_death_test_style, death_test_style);
+  // Always set the death_test_style flag to "threadsafe" regardless of its previous value
+  // This is needed because some tests might internally reset this value, and we need to 
+  // ensure all death tests run in threadsafe mode as required by Envoy
+  ::absl::SetFlag(&FLAGS_gtest_death_test_style, "threadsafe");
 }
 
 } // namespace Envoy