Tests depending on boringssl vs openssl

[dcillera]

Title: Tests with hard-coded numbers depending on platform/library

Description:

Working with OpenSSL and different Builders (Ubuntu based and Rockylinux based), we're observing that several tests are expecting hard-coded values for the processed number of bytes, and the actual value depends on the environment and the library used.

For example, in tls_inspector_integration_test.JA3FingerprintIsSet:

envoy/test/extensions/filters/listener/tls_inspector/tls_inspector_integration_test.cc

Line 209 in 35c166b

115);

the actual values will be different in the following cases:

Ubuntu + BoringSSL: 115
Ubuntu + OpenSSL 3.0.7: 145
Ubuntu + OpenSSL 3.2.2: 155
Rockylinux + OpenSSL 3.2.2: 135

Another example is in the result yaml file expected in the tcp_grpc_access_log_integration_test in the test SslNotTerminated.

It would make sense to think of a test independent from the platform and library.

[optional Relevant Links:]

Any extra documentation required to understand the issue.

[adisuissa]

cc @ggreenway @alyssawilk @yanavlasov

[ggreenway]

OpenSSL is not a supported configuration. You could try https://github.com/envoyproxy/envoy-openssl.

But in this case, it might be possible to hard-code the ClientHello payload, which would be an equally valid test, and then the test wouldn't depend on the the behavior of the ssl library.

[github-actions]

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

[dcillera]

@adisuissa could you please mark this issue as no stalebot?

[ggreenway]

@dcillera what action are you expecting out of this? We generally only mark things no-stalebot if there's ongoing work, or at least a plan, but it hasn't yet completed.

[dcillera]

I've had no time to implement a solution (based, for example, on suggestion above). It's still in my plan to go back to this whenever possible.