-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Open
Labels
Description
Title: ext_proc : If ProcessingResponse is empty, taking it as no-mutation for the request and ok response
Description:
Currently, Envoy ext_proc API is asking the ext_proc server to set oneof the field in the ProcessingResponse:
| message ProcessingResponse { |
However, today some ext_proc users are not following the API and sending empty ProcessingResponse if they don't want to mutate the requests. In this case, Envoy take it as Spurious response:
| processing_status = absl::FailedPreconditionError("unhandled message"); |
The proposal is that if server sends an empty ProcessingResponse, just taking it as no mutation, and Envoy take the response status as Ok().
To achieve this, we also need to remove option (validate.required) = true; from the ProcessingResponse API:
| option (validate.required) = true; |