Does the default envoy-gateway-config still need a patch for ratelimit image pull policy? #6033
nelljerram
started this conversation in
General
Replies: 1 comment 4 replies
-
@nelljerram the helm template is needed, because there's an option to change the ratelimit image repo/tag in the helm values files, which was a popular user ask (for air gapped cases) |
Beta Was this translation helpful? Give feedback.
4 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
I'm working in the area of envoy-gateway-config customization, and so am interested in the current default, which includes:
IIUC this comes from https://github.com/envoyproxy/gateway/blob/main/charts/gateway-helm/templates/_helpers.tpl#L167-L175.
My question is whether this patch is still needed, because it seems to me that
expectedRateLimitContainers
already defines theenvoy-ratelimit
container withimagePullPolicy: IfNotPresent
: https://github.com/envoyproxy/gateway/blob/main/internal/infrastructure/kubernetes/ratelimit/resource.go#L156Obviously this isn't a huge deal, but for me it would be nicer if the default envoy-gateway-config could be more minimal.
Beta Was this translation helpful? Give feedback.
All reactions