Does the default envoy-gateway-config still need a patch for ratelimit image pull policy?

[nelljerram]

I'm working in the area of envoy-gateway-config customization, and so am interested in the current default, which includes:

          patch:
            type: StrategicMerge
            value:
              spec:
                template:
                  spec:
                    containers:
                    - imagePullPolicy: IfNotPresent
                      name: envoy-ratelimit

IIUC this comes from https://github.com/envoyproxy/gateway/blob/main/charts/gateway-helm/templates/_helpers.tpl#L167-L175.

My question is whether this patch is still needed, because it seems to me that expectedRateLimitContainers already defines the envoy-ratelimit container with imagePullPolicy: IfNotPresent: https://github.com/envoyproxy/gateway/blob/main/internal/infrastructure/kubernetes/ratelimit/resource.go#L156

Obviously this isn't a huge deal, but for me it would be nicer if the default envoy-gateway-config could be more minimal.

[arkodg]

@nelljerram the helm template is needed, because there's an option to change the ratelimit image repo/tag in the helm values files, which was a popular user ask (for air gapped cases)

[nelljerram]

Thanks @arkodg. I understand wanting to customize the image repo/tag. But why the pull policy?

[arkodg]

cc @zhaohuabing, do you remember why it was added

[zhaohuabing]

The EG helm chart supports customizing both the image and pull policy for the ratelimit image.

{{- define "eg.default-envoy-gateway-config" -}}
provider:
  type: Kubernetes
  kubernetes:
    rateLimitDeployment:
      container:
        image: {{ include "eg.ratelimit.image" . }}
      {{- if (or .Values.global.imagePullSecrets .Values.global.images.ratelimit.pullSecrets) }}
      pod:
        {{- include "eg.ratelimit.image.pullSecrets" . | nindent 8 }}
      {{- end }}
      {{- with .Values.global.images.ratelimit.pullPolicy }}
      patch:
        type: StrategicMerge
        value:
          spec:
            template:
              spec:
                containers:
                - name: envoy-ratelimit
                  imagePullPolicy: {{ . }}
      {{- end }}

[nelljerram]

OK. Is there a common scenario where someone will want a value other than imagePullPolicy: IfNotPresent?