follow up: make port 19001 configurable

[zirain]

EG use 0.0.0.0:19001 for health check and prometheus metric, should make this configuration.

[arkodg]

+1 to making it configurable, that is something that can be done in the next release in v0.6, but shouldnt we have a dedicated port for prometheus, maybe 19002 by default ?

[zirain]

+1 to making it configurable, that is something that can be done in the next release in v0.6, but shouldnt we have a dedicated port for prometheus, maybe 19002 by default ?

why not share the same port with health check?

[arkodg]

good point, if worker thread is different for different requests / starvation is unlikely, this is fine, until we add an API to make it configurable

[shawnh2]

hi, interested in picking this one up.

BTW, any thoughs on #244 ? it seems like we can also make xDS server port configurable.

[arkodg]

yah both issues make sense @shawnh2

[github-actions]

This issue has been automatically marked as stale because it has not had activity in the last 30 days.