Skip to content

Support ServiceImport AppProtocol parsing, similar to Service parsing #5485

Closed
@nareddyt

Description

@nareddyt

Context

Service and ServiceImport both have an AppProtocol field.

Specs:

EG currently parses the AppProtocol field for Service resources.

if servicePort.AppProtocol != nil {
switch *servicePort.AppProtocol {
case "kubernetes.io/h2c":
protocol = ir.HTTP2
case "grpc":
protocol = ir.GRPC
}
}

Problem

During some refactoring in #5451, we found that EG does NOT parse AppProtocol from ServiceImport CR. https://github.com/envoyproxy/gateway/pull/5451/files#r1990414195

Ask

Can we apply the same AppProtocol parsing to ServiceImport that we currently support on Service?

I assume we should, as Service and ServiceImport are mostly interchangeable. But should we support the same AppProtocol values for both resources?

Metadata

Metadata

Assignees

Labels

area/translatorIssues related to Gateway's translation service, e.g. translating Gateway APIs into the IR.kind/featurenew feature

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions