Rate Limit implementation does not respond with `Retry-After-Seconds` header

[sando38]

Description:
When rate-limited, these are the response headers:

HTTP/2 429
content-length: 18
content-type: text/plain
date: Mon, 07 Apr 2025 15:30:02 GMT

However, it would be great to also have these

'Retry-After-Seconds': '60',
 'Retry-After': 'Mon, 07 Apr 2025 14:55:01 GMT', 

Repro steps:
Enable rate-limiting according to the gateway documentation and provoke the rate-limit according to the documentation.

Note:
As discussed in Slack, I should open a bug report here.

seems like a bug, can you raise an issue
we do enable it https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/filters/http/ratelimit/v3/rate_limit.proto#envoy-v3-api-enum-ex[…]mitheadersrfcversion

gateway/internal/xds/translator/ratelimit.go

Line 159 in f89091f

rateLimitFilterProto.EnableXRatelimitHeaders = ratelimitfilterv3.RateLimit_DRAFT_VERSION_03

Environment:
K8S v1.30, Envoy GW v1.3.2

Logs:
None.

Thank you, very much appreciated.

[zirain]

can you share the output of egctl config envoy-proxy?

[sando38]

egctl.json

Voila! 😄

[zirain]

what kind of ratelimit you're using? local or global?

From the configuration, it seems like local.

[sando38]

From the configuration, it seems like local.

yes, correct. I "played" with local.

[arkodg]

we'll need to add the same logic for local ratelimit

gateway/internal/xds/translator/local_ratelimit.go

Line 150 in f89091f

localRl := &localrlv3.LocalRateLimit{

to enable_x_ratelimit_headers
https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/filters/http/local_ratelimit/v3/local_rate_limit.proto#envoy-v3-api-msg-extensions-filters-http-local-ratelimit-v3-localratelimit