Skip to content

docs: Fix Podname used as command in HTTPRoute Docs (Latest) #5702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

melsal13
Copy link
Collaborator

@melsal13 melsal13 commented Apr 9, 2025

What type of PR is this?
Removes the podname outputs from commands in the HTTPRoute docs.

What this PR does / why we need it:
If the user copied the command as is, it would fail. Removing the podname helps resolve this issue.

Which issue(s) this PR fixes:
Fixes: N/A

Release Notes: No

@melsal13 melsal13 requested a review from a team as a code owner April 9, 2025 21:57
@melsal13
Copy link
Collaborator Author

melsal13 commented Apr 9, 2025

@arkodg Please review when you get a chance!

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@arkodg arkodg requested review from a team April 9, 2025 22:29
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.27%. Comparing base (fd09db2) to head (e0310e7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5702   +/-   ##
=======================================
  Coverage   65.27%   65.27%           
=======================================
  Files         213      213           
  Lines       34108    34108           
=======================================
  Hits        22264    22264           
+ Misses      10505    10504    -1     
- Partials     1339     1340    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zirain
Copy link
Member

zirain commented Apr 10, 2025

/retest

@zirain zirain merged commit 52d8f9c into envoyproxy:main Apr 10, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants