bug when grid in scrollable container

[valuta777]

  [x] bug
  [ ] feature request
  [ ] enhancement

Expected behavior

usual behavior in a scrollable container

Actual behavior

In scrollable container when scrollTop is bigger than 0, dragging ghost jump up for scrollTop value.

Posible fix

in ngx-widget-grid.js in NgxWidgetMoverDirective.prototype.onMove method

 var scrollLeft = window.pageXOffset || document.documentElement.scrollLeft, scrollTop = window.pageYOffset || document.documentElement.scrollTop;
desiredPosition.top = Math.min(Math.max(dragPositionY - this.moverOffset.top + scrollTop, 0), gridDimensions.height - startRender.height+ scrollTop - 1);
desiredPosition.left = Math.min(Math.max(dragPositionX - this.moverOffset.left + scrollLeft, 0), gridDimensions.width - startRender.width + scrollLeft - 1);

Video of behavior

https://drive.google.com/file/d/1036t40UCISyRpJ1PMvXy9_1iyxlbNcF1/view?usp=sharing

Environment details

• Angular version: 5.2.x

• OS and version:

• Browser: [Chrome]

[DBHATT014]

did you fix it

[valuta777]

@DBHATT014 now it's fixed locally in my solution, I'm waiting for a new release
widgetMover.directive.ts 119-121

 var scrollLeft = window.pageXOffset || document.documentElement.scrollLeft, scrollTop = window.pageYOffset || document.documentElement.scrollTop;
      desiredPosition.top = Math.min(Math.max(dragPositionY - this.moverOffset.top + scrollTop, 0), gridDimensions.height - startRender.height + scrollTop - 1);
      desiredPosition.left = Math.min(Math.max(dragPositionX - this.moverOffset.left + scrollLeft, 0), gridDimensions.width - startRender.width + scrollLeft - 1);

Also for resize
widgetResizer.directive.ts 136-150

var scrollLeft = window.pageXOffset || document.documentElement.scrollLeft, scrollTop = window.pageYOffset || document.documentElement.scrollTop;
      if (this.moveUpAllowed) {
        delta.top = Math.min(Math.max(dragPositionY - this.draggerOffset.top + scrollTop, 0), gridDims.height) - startRender.top + scrollTop;
        delta.top = Math.min(delta.top, startRender.height - MIN_HEIGHT);
      } else if (this.moveDownAllowed) {
        delta.bottom = startRender.bottom - Math.min(Math.max(dragPositionY - this.draggerOffset.bottom + scrollTop, 0), gridDims.height + scrollTop);
        delta.bottom = Math.min(delta.bottom, startRender.height - MIN_HEIGHT);
      }

      if (this.moveLeftAllowed) {
        delta.left = Math.min(Math.max(dragPositionX - this.draggerOffset.left + scrollLeft, 0), gridDims.width) - startRender.left + scrollLeft;
        delta.left = Math.min(delta.left, startRender.width - MIN_WIDTH);
      } else if (this.moveRightAllowed) {
        delta.right = startRender.right - Math.min(Math.max(dragPositionX - this.draggerOffset.right + scrollLeft, 0), gridDims.width + scrollLeft);
        delta.right = Math.min(delta.right, startRender.width - MIN_WIDTH);
      }

[DBHATT014]

i tried 1st 1 fix and its working fine thanx

[nialish]

how to have scroll when add new widgets?

[p91paul]

@envyN do you have this on your radar? do you think @valuta777 solution is fine and would you accept a pull request with that code?