Cached entries always have an impact 0

[virtuaris]

Hi there,

first of all many thanks for your great work, very appreciated.

I just wonder if this is an intended behaviour or kind of a bug:
If caching is activated via $manager->setCache($cache); every request on a cached request will leave impact as 0 since the code setting impact is never reached (done in Manager.php function processFilters()). Thus any further processing based on impact assumes a clean, non-offending request.
Imho caching should just avoid the re-application of filter rules but it should not bypass actions taken on impact. In other words why should an offending request be considered harmless just by the fact that it has been cached?
Bests
Harald

[geralt]

Hi @virtuaris

In my opinion it's a bug. It's necessary saving more information into cache, not only $filterMatches also $impact and $reports. In this way, when we get data from cache, into runFilters() function, we have all information.