This repository has been archived by the owner on Nov 17, 2022. It is now read-only.
Add autofocus to sidebar input, and support navigating filtered results. #305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the sidebars in the browser have focus in the search bar when they come up, so it seems like this one should too. It also helps alleviate #304, which doesn't seem doable currently (
el.focus()
when called from a command handler never seems to work. I can't tell if there's a bug on file for that yet, or if it's even a bug at all vs a design choice).The second commit is much meatier but basically just adds the notion of a currently "selected" tab to the sidebar. This allows easier navigation of search results with the arrow keys. The behavior I've used was chosen by what "feels" good, and I've added comments to explain the non-obvious parts.
Some notes, most of which are also in comments: