[Security Solution] removing preventing save a Timeline with an adhoc dataview (elastic#240537)

## Summary

This PR makes a small change to the save Timeline flow and removes the
code that was preventing users from saving a Timeline that was using an
adhoc dataview.

We don't really need to prevent that to happen, as Timeline only saves
the list of indices anyway, and it has a way to create an adhoc data
view on the fly when opening from that list of indices.

#### Previous behavior


https://github.com/user-attachments/assets/b316b46b-4436-41c3-851b-e4831ca7e331

### New behavior


https://github.com/user-attachments/assets/1583d1b5-5293-4bf1-b4c6-6699d6289ec5

The PR actually makes a code change that does not save any dataViewId if
the data view is adhoc. We do not need to save the id of adhoc data
views as they are ephemeris. They will most likely not exist when users
reopen the Timeline. We have enough information with the list of indices
to rebuilt a new adhoc data view on the fly next time the Timeline is
reopened.

## TODO

- [x] write unit tests
- [ ] create doc ticket

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [x] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

Author: PhilippeOberti

x-pack/solutions/security/plugins/security_solution/public/timelines/store/middlewares/timeline_save.test.ts

@@ -85,19 +85,58 @@ describe('Timeline save middleware', () => {
       })
     );
     await store.dispatch(saveTimeline({ id: TimelineId.test, saveAsNew: false }));
+    expect(mockDataViewManagerState).toBeDefined();
+    expect(startTimelineSavingMock).toHaveBeenCalled();
+    expect(persistTimeline as unknown as jest.Mock).toHaveBeenCalledWith(
+      expect.objectContaining({
+        timeline: expect.objectContaining({
+          dataViewId: mockDataViewManagerState.dataViewManager.timeline.dataViewId,
+          indexNames: ['test'],
+        }),
+      })
+    );
+    expect(refreshTimelines as unknown as jest.Mock).toHaveBeenCalled();
+    expect(endTimelineSavingMock).toHaveBeenCalled();
+    expect(selectTimelineById(store.getState(), TimelineId.test)).toEqual(
+      expect.objectContaining({
+        version: 'newVersion',
+        changed: false,
+      })
+    );
+  });
 
+  it('should not save any adhoc dataViewId when persisting a timeline', async () => {
+    dataView = getMockDataViewWithMatchedIndices();
+    dataView.version = undefined;
+    (kibanaMock.plugins.onStart as jest.Mock).mockReturnValue({
+      dataViews: {
+        found: true,
+        contract: { get: () => dataView },
+      },
+    });
+    (persistTimeline as jest.Mock).mockResolvedValue({
+      savedObjectId: 'soid',
+      version: 'newVersion',
+    });
+
+    await store.dispatch(setChanged({ id: TimelineId.test, changed: true }));
+    expect(selectTimelineById(store.getState(), TimelineId.test)).toEqual(
+      expect.objectContaining({
+        version: null,
+        changed: true,
+      })
+    );
+    await store.dispatch(saveTimeline({ id: TimelineId.test, saveAsNew: false }));
     expect(mockDataViewManagerState).toBeDefined();
     expect(startTimelineSavingMock).toHaveBeenCalled();
-    expect(persistTimeline as unknown as jest.Mock).toHaveBeenCalled();
-    // TODO: skipped the assertion below until the new picker is enabled https://github.com/elastic/security-team/issues/11959
-    // expect(persistTimeline as unknown as jest.Mock).toHaveBeenCalledWith(
-    //   expect.objectContaining({
-    //     timeline: expect.objectContaining({
-    //       dataViewId: mockDataViewManagerState.dataViewManager.timeline.dataViewId,
-    //       indexNames: ['test'],
-    //     }),
-    //   })
-    // );
+    expect(persistTimeline as unknown as jest.Mock).toHaveBeenCalledWith(
+      expect.objectContaining({
+        timeline: expect.objectContaining({
+          dataViewId: null,
+          indexNames: ['test'],
+        }),
+      })
+    );
     expect(refreshTimelines as unknown as jest.Mock).toHaveBeenCalled();
     expect(endTimelineSavingMock).toHaveBeenCalled();
     expect(selectTimelineById(store.getState(), TimelineId.test)).toEqual(

x-pack/solutions/security/plugins/security_solution/public/timelines/store/middlewares/timeline_save.ts

@@ -85,6 +85,11 @@ export const saveTimelineMiddleware: (kibana: CoreStart) => Middleware<{}, State
       storeState.app.enableExperimental.newDataViewPickerEnabled;
 
     let experimentalSelectedPatterns: string[] = [];
+    let dataViewId: string | null = null;
+
+    if (!experimentalIsDataViewEnabled) {
+      dataViewId = selectedDataViewIdSourcerer;
+    }
 
     // NOTE: remove eslint override above after the experimental picker is stabilized
     if (experimentalIsDataViewEnabled && experimentalDataViewId) {
@@ -95,13 +100,8 @@ export const saveTimelineMiddleware: (kibana: CoreStart) => Middleware<{}, State
       if (plugins.dataViews.found) {
         const experimentalDataView = await plugins.dataViews.contract.get(experimentalDataViewId);
 
-        if (!experimentalDataView.isPersisted()) {
-          return kibana.notifications.toasts.addError(
-            new Error('Persisting timelines with adhoc data views is not allowed'),
-            {
-              title: 'Error persisting timeline',
-            }
-          );
+        if (experimentalDataView.isPersisted()) {
+          dataViewId = experimentalDataViewId;
         }
 
         experimentalSelectedPatterns = experimentalDataView.getIndexPattern().split(',');
@@ -111,9 +111,6 @@ export const saveTimelineMiddleware: (kibana: CoreStart) => Middleware<{}, State
     const indexNames = experimentalIsDataViewEnabled
       ? experimentalSelectedPatterns
       : selectedPatternsSourcerer;
-    const dataViewId = experimentalIsDataViewEnabled
-      ? experimentalDataViewId
-      : selectedDataViewIdSourcerer;
 
     store.dispatch(startTimelineSaving({ id: localTimelineId }));