Add Go to Definition feature

QuangNguyenMinh123 · QuangNguyenMinh123 · commit f65bb990325f · 2026-02-19T11:12:49.000+07:00
diff --git a/src/SeerEditorManagerWidget.cpp b/src/SeerEditorManagerWidget.cpp
@@ -481,6 +481,10 @@ bool SeerEditorManagerWidget::editorAutoSourceReload () const {
     return _editorAutoSourceReload;
 }
 
+void SeerEditorManagerWidget::setSourceBrowserWidget (SeerSourceBrowserWidget* sourceBrowserWidget) {
+    _sourceBrowserWidget = sourceBrowserWidget;
+}
+
 void SeerEditorManagerWidget::handleText (const QString& text) {
 
     // Update the current line.
@@ -801,6 +805,41 @@ void SeerEditorManagerWidget::handleText (const QString& text) {
                 i->widget->sourceArea()->eraseColorCurrentLine(line_text.toInt());
             }
         }
+    }else if ( text.contains(QRegularExpression("^([0-9]+)\\^done,symbols={")))
+    {
+        if (text.startsWith(_idTypeDefinition + "^done,symbols={") || text.startsWith(_idFunctionDefinition + "^done,symbols={") ||
+            text.startsWith(_idVariableDefinition + "^done,symbols={"))          // Handle Go to Definition
+        {
+            //^10done,symbols={debug=[{filename=" ",fullname=" ",
+            // symbols=[{line=" ",name="uwTick",type="volatile uint32_t",description="volatile uint32_t uwTick;"},}]}]
+            QString debug_text = Seer::parseFirst(text, "debug=", '[', ']', false);
+            QStringList filenames_list = Seer::parse(debug_text, "", '{', '}', false);
+
+            for (const auto& filename_entry : filenames_list) {
+
+                QString filename_text = Seer::parseFirst(filename_entry, "filename=", '"', '"', false);
+                QString fullname_text = Seer::parseFirst(filename_entry, "fullname=", '"', '"', false);
+
+                // If that file is not in source browser, skip it
+                if (_sourceBrowserWidget->findFileWithRegrex(fullname_text).isEmpty())
+                    continue;
+
+                QString symbols_text = Seer::parseFirst(filename_entry, "symbols=", '[', ']', false);
+                QStringList symbols_list = Seer::parse(symbols_text, "", '{', '}', false);
+
+                for (const auto& symbol_entry : symbols_list) {
+
+                    QString line_text = Seer::parseFirst(symbol_entry, "line=", '"', '"', false);
+                    QString name_text = Seer::parseFirst(symbol_entry, "name=", '"', '"', false);
+                    // name_text may be st like: function_name(params...) , so only extract function_name part
+                    name_text = name_text.section('(', 0, 0).trimmed();
+                    if (name_text == _gotoDefIdentifier)           // you found it! Open file
+                    {
+                        handleOpenFile(filename_text, fullname_text, line_text.toInt());
+                    }
+                }
+            }
+        }
     }
     else{
         // Ignore others.
@@ -1060,6 +1099,7 @@ SeerEditorWidgetSource* SeerEditorManagerWidget::createEditorWidgetTab (const QS
     QObject::connect(editorWidget->sourceArea(), &SeerEditorWidgetSourceArea::addStructVisualizer,           this, &SeerEditorManagerWidget::handleAddStructVisualizer);
     QObject::connect(editorWidget,               &SeerEditorWidgetSource::addAlternateDirectory,             this, &SeerEditorManagerWidget::handleAddAlternateDirectory);
     QObject::connect(editorWidget->sourceArea(), &SeerEditorWidgetSourceArea::addToMouseNavigation,          this, &SeerEditorManagerWidget::handleAddToMouseNavigation);
+    QObject::connect(editorWidget->sourceArea(), &SeerEditorWidgetSourceArea::signalGotoDefinition,          this, &SeerEditorManagerWidget::gotoDefinitionForwarder);
 
     // Send the Editor widget the command to load the file. ??? Do better than this.
     editorWidget->sourceArea()->handleText(text);
@@ -1124,6 +1164,7 @@ SeerEditorWidgetSource* SeerEditorManagerWidget::createEditorWidgetTab (const QS
     QObject::connect(editorWidget->sourceArea(), &SeerEditorWidgetSourceArea::addStructVisualizer,           this, &SeerEditorManagerWidget::handleAddStructVisualizer);
     QObject::connect(editorWidget,               &SeerEditorWidgetSource::addAlternateDirectory,             this, &SeerEditorManagerWidget::handleAddAlternateDirectory);
     QObject::connect(editorWidget->sourceArea(), &SeerEditorWidgetSourceArea::addToMouseNavigation,          this, &SeerEditorManagerWidget::handleAddToMouseNavigation);
+    QObject::connect(editorWidget->sourceArea(), &SeerEditorWidgetSourceArea::signalGotoDefinition,          this, &SeerEditorManagerWidget::gotoDefinitionForwarder);
 
     // Load the file.
     editorWidget->sourceArea()->open(fullname, QFileInfo(file).fileName());
@@ -1633,4 +1674,27 @@ void SeerEditorManagerWidget::mousePressEvent(QMouseEvent *event)
     {
         QWidget::mousePressEvent(event);
     }
-}
+}
+
+/***********************************************************************************************************************
+ * Functions for handling tracing identifier                                                                           *
+ **********************************************************************************************************************/
+void SeerEditorManagerWidget::gotoDefinitionForwarder(const QString& identifier)
+{
+    _gotoDefIdentifier = identifier;
+
+    // Create a unique ID for the function definition request and send the command to gdb
+    _idFunctionDefinition = QString::number(Seer::createID());
+    QString gdbCommand = _idFunctionDefinition + "-symbol-info-functions --name " + _gotoDefIdentifier;
+    emit gotoDefinitionForward(gdbCommand);
+
+    // Create a unique ID for the variable definition request and send the command to gdb
+    _idVariableDefinition = QString::number(Seer::createID());
+    gdbCommand = _idVariableDefinition + "-symbol-info-variables --name " + _gotoDefIdentifier;
+    emit gotoDefinitionForward(gdbCommand);
+
+    // Create a unique ID for the type definition request and send the command to gdb
+    _idTypeDefinition = QString::number(Seer::createID());
+    gdbCommand = _idTypeDefinition + "-symbol-info-types --name " + _gotoDefIdentifier;
+    emit gotoDefinitionForward(gdbCommand);
+}
diff --git a/src/SeerEditorManagerWidget.h b/src/SeerEditorManagerWidget.h
@@ -8,6 +8,7 @@
 #include "SeerEditorManagerEntry.h"
 #include "SeerHighlighterSettings.h"
 #include "SeerKeySettings.h"
+#include "SeerSourceBrowserWidget.h"
 #include <QtGui/QFont>
 #include <QtWidgets/QWidget>
 #include <QtCore/QMap>
@@ -75,6 +76,7 @@ class SeerEditorManagerWidget : public QWidget, protected Ui::SeerEditorManagerW
         const QString&                                  editorExternalEditorCommand         () const;
         void                                            setEditorAutoSourceReload           (bool flag);
         bool                                            editorAutoSourceReload              () const;
+        void                                            setSourceBrowserWidget              (SeerSourceBrowserWidget* sourceBrowserWidget);
 
     public slots:
         void                                            handleText                          (const QString& text);
@@ -117,6 +119,7 @@ class SeerEditorManagerWidget : public QWidget, protected Ui::SeerEditorManagerW
         void                                            handleTextSearchToolButtonClicked   ();
         void                                            handleHelpToolButtonClicked         ();
         void                                            handleAddAlternateDirectory         (QString path);
+        void                                            gotoDefinitionForwarder             (const QString& identifier);
 
     signals:
         void                                            refreshBreakpointsList              ();
@@ -141,6 +144,7 @@ class SeerEditorManagerWidget : public QWidget, protected Ui::SeerEditorManagerW
         void                                            requestSourceAndAssembly            (QString address);
         void                                            showMessage                         (QString message, int time);
         void                                            assemblyTabShown                    (bool shown);
+        void                                            gotoDefinitionForward               (const QString& identifier, bool ignoreErrors = false);
 
     private:
         SeerEditorWidgetSource*                         currentEditorWidgetTab              ();
@@ -155,6 +159,7 @@ class SeerEditorManagerWidget : public QWidget, protected Ui::SeerEditorManagerW
 
         SeerEditorManagerEntries                        _entries;
         SeerHighlighterSettings                         _editorHighlighterSettings;
+        SeerSourceBrowserWidget*                        _sourceBrowserWidget;   // Point to source browser widget in SeerGdbWidget 
         bool                                            _editorHighlighterEnabled;
         QFont                                           _editorFont;
         QStringList                                     _editorAlternateDirectories;
@@ -179,5 +184,11 @@ class SeerEditorManagerWidget : public QWidget, protected Ui::SeerEditorManagerW
         // list of cursor positions for mouse navigation (back/forward)
         QList<SeerEditorWidgetSourceArea::SeerCurrentFile>                      _listForwardFiles;
         int                                             _forwardFilesIndex = -1;
+
+        // _id of identifier for Go to definition
+        QString                                         _idFunctionDefinition;
+        QString                                         _idVariableDefinition;
+        QString                                         _idTypeDefinition;
+        QString                                         _gotoDefIdentifier; 
 };
 
diff --git a/src/SeerEditorWidgetSource.h b/src/SeerEditorWidgetSource.h
@@ -145,12 +145,14 @@ class SeerEditorWidgetSourceArea : public SeerPlainTextEdit {
         void                                        showReloadBar                       (bool flag);
         void                                        highlighterSettingsChanged          ();
         void                                        addToMouseNavigation                (const SeerCurrentFile& currentFile);
+        void                                        signalGotoDefinition                (const QString& identifier);
 
     public slots:
         void                                        handleText                          (const QString& text);
         void                                        handleHighlighterSettingsChanged    ();
         void                                        handleWatchFileModified             (const QString& path);
         void                                        handleBreakpointToolTip             (QPoint pos, const QString& text);
+        void                                        handleGotoDefinitionF12             ();
 
     protected:
         void                                        resizeEvent                         (QResizeEvent* event);
@@ -170,6 +172,8 @@ class SeerEditorWidgetSourceArea : public SeerPlainTextEdit {
 
     private:
         void                                        handleCursorPositionChanged         ();
+        bool                                        isValidIdentifier                   (const QString& text);
+
         QString                                     _fullname;
         QString                                     _file;
         QString                                     _alternateDirectory;
diff --git a/src/SeerEditorWidgetSourceAreas.cpp b/src/SeerEditorWidgetSourceAreas.cpp
@@ -72,6 +72,10 @@ SeerEditorWidgetSourceArea::SeerEditorWidgetSourceArea(QWidget* parent) : SeerPl
     // Connect cursor position changed signal.
     QObject::connect(this,          &QPlainTextEdit::cursorPositionChanged,                 this, &SeerEditorWidgetSourceArea::handleCursorPositionChanged);
 
+    // Add F12 shortcut. F12 -> SeerEditorWidgetSourceArea::handleGotoDefinitionF12 -> emit gotoDefinition(wordUnderCursor)
+    QShortcut *shortcutF12 = new QShortcut(QKeySequence("F12"), this);
+    QObject::connect(shortcutF12,   &QShortcut::activated,                                  this, &SeerEditorWidgetSourceArea::handleGotoDefinitionF12);
+
     setCurrentLine(0);
 
     updateMarginAreasWidth(0);
@@ -2051,6 +2055,7 @@ void SeerEditorWidgetSourceBreakPointArea::mouseReleaseEvent (QMouseEvent* event
  **********************************************************************************************************************/
 void SeerEditorWidgetSourceArea::mousePressEvent(QMouseEvent *event)
 {
+    // This part is for mouse navigation feature 
     if (event->button() == Qt::XButton1 || event->button() == Qt::XButton2) {
         // Avoid the default back/forward action
         _ignoreThumbMouseEvent ++;
@@ -2086,3 +2091,58 @@ void SeerEditorWidgetSourceArea::handleCursorPositionChanged()
         }
     } );
 }
+
+/***********************************************************************************************************************
+ * Go to definition (F12) feature                                                                                            *
+ **********************************************************************************************************************/
+// Check text and decide if that text is valid identifier (function, variable, type name)
+bool SeerEditorWidgetSourceArea::isValidIdentifier(const QString& text) 
+{
+    static const QSet<QString> keywords = {
+        // Add your C and C++ keywords as QString literals here
+        "auto", "break", "case", "char", "const", "continue", "default", "do", "double",
+        "else", "enum", "extern", "float", "for", "goto", "if", "inline", "int", "long",
+        "register", "restrict", "return", "short", "signed", "sizeof", "static", "struct",
+        "switch", "typedef", "union", "unsigned", "void", "volatile", "while", "_Alignas",
+        "_Alignof", "_Atomic", "_Bool", "_Complex", "_Generic", "_Imaginary", "_Noreturn",
+        "_Static_assert", "_Thread_local",
+
+        "alignas", "alignof", "and", "and_eq", "asm", "bitand", "bitor", "bool", "catch",
+        "char16_t", "char32_t", "class", "compl", "const_cast", "constexpr", "decltype",
+        "delete", "dynamic_cast", "explicit", "export", "false", "friend", "mutable", "namespace",
+        "new", "noexcept", "not", "not_eq", "nullptr", "operator", "or", "or_eq", "private",
+        "protected", "public", "reinterpret_cast", "static_assert", "static_cast", "template",
+        "this", "thread_local", "throw", "true", "try", "typeid", "typename", "using",
+        "virtual", "wchar_t", "xor", "xor_eq"
+    };
+
+    if (text.isEmpty())
+        return false;
+
+    if (keywords.contains(text))
+        return false;
+
+    QChar firstChar = text[0];
+    if (!firstChar.isLetter() && firstChar != '_')
+        return false;
+
+    for (int i = 1; i < text.size(); ++i) {
+        QChar ch = text[i];
+        if (!ch.isLetterOrNumber() && ch != '_')
+            return false;
+    }
+
+    return true;
+}
+
+// When F12 is pressed, try to look for the word under cursor, if it's a valid identifier then emit signalGotoDefinition
+void SeerEditorWidgetSourceArea::handleGotoDefinitionF12()
+{
+    QTextCursor cursor = textCursor();
+    cursor.select(QTextCursor::WordUnderCursor);
+    QString wordUnderCursor = cursor.selectedText();
+    if (isValidIdentifier(wordUnderCursor))
+    {
+        emit signalGotoDefinition(wordUnderCursor);
+    }
+}
diff --git a/src/SeerGdbWidget.cpp b/src/SeerGdbWidget.cpp
@@ -358,6 +358,7 @@ SeerGdbWidget::SeerGdbWidget (QWidget* parent) : QWidget(parent) {
     QObject::connect(sourceCommandLogsSplitter,                                 &QSplitter::splitterMoved,                                                                  this,                                                           &SeerGdbWidget::handleSplitterMoved);
     QObject::connect(stackThreadManagerSplitter,                                &QSplitter::splitterMoved,                                                                  this,                                                           &SeerGdbWidget::handleSplitterMoved);
     QObject::connect(commandLogsWidget->gdbOutputLog(),                         &SeerGdbLogWidget::refreshBreakpointsList,                                                  this,                                                           &SeerGdbWidget::handleGdbGenericpointList);
+    QObject::connect(editorManagerWidget,                                       &SeerEditorManagerWidget::gotoDefinitionForward,                                            this,                                                           &SeerGdbWidget::handleGdbCommand);
 
 #if SEER_GDB_LOGOUT == 1
     // Direct all GdbWidget and GdbMonitor log to GDB Log, for debugging
@@ -369,6 +370,9 @@ SeerGdbWidget::SeerGdbWidget (QWidget* parent) : QWidget(parent) {
 
     // Restore window settings.
     readSettings();
+
+    // Set source browser widget for editor manager widget, so that editor manager can check if a file is in source browser before opening it
+    editorManagerWidget->setSourceBrowserWidget(sourceLibraryManagerWidget->sourceBrowserWidget());
 }
 
 SeerGdbWidget::~SeerGdbWidget () {
@@ -3854,4 +3858,3 @@ void SeerGdbWidget::delay (int seconds) {
         QCoreApplication::processEvents(QEventLoop::AllEvents, 100);
     }
 }
-

Original file line number	Diff line number	Diff line change
`@@ -358,6 +358,7 @@ SeerGdbWidget::SeerGdbWidget (QWidget* parent) : QWidget(parent) {`
`358`	`358`	`QObject::connect(sourceCommandLogsSplitter, &QSplitter::splitterMoved, this, &SeerGdbWidget::handleSplitterMoved);`
`359`	`359`	`QObject::connect(stackThreadManagerSplitter, &QSplitter::splitterMoved, this, &SeerGdbWidget::handleSplitterMoved);`
`360`	`360`	`QObject::connect(commandLogsWidget->gdbOutputLog(), &SeerGdbLogWidget::refreshBreakpointsList, this, &SeerGdbWidget::handleGdbGenericpointList);`
	`361`	`+ QObject::connect(editorManagerWidget, &SeerEditorManagerWidget::gotoDefinitionForward, this, &SeerGdbWidget::handleGdbCommand);`
`361`	`362`
`362`	`363`	`#if SEER_GDB_LOGOUT == 1`
`363`	`364`	`// Direct all GdbWidget and GdbMonitor log to GDB Log, for debugging`
`@@ -369,6 +370,9 @@ SeerGdbWidget::SeerGdbWidget (QWidget* parent) : QWidget(parent) {`
`369`	`370`
`370`	`371`	`// Restore window settings.`
`371`	`372`	`readSettings();`
	`373`	`+`
	`374`	`+ // Set source browser widget for editor manager widget, so that editor manager can check if a file is in source browser before opening it`
	`375`	`+ editorManagerWidget->setSourceBrowserWidget(sourceLibraryManagerWidget->sourceBrowserWidget());`
`372`	`376`	`}`
`373`	`377`
`374`	`378`	`SeerGdbWidget::~SeerGdbWidget () {`
`@@ -3854,4 +3858,3 @@ void SeerGdbWidget::delay (int seconds) {`
`3854`	`3858`	`QCoreApplication::processEvents(QEventLoop::AllEvents, 100);`
`3855`	`3859`	`}`
`3856`	`3860`	`}`
`3857`		`-`