[#2142] touch events handling #3150
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/docs/locales/en.json
m0ksem
requested changes
Mar 20, 2023
| @@ -0,0 +1,88 @@ | |||
| import { ref, onBeforeUnmount, type Ref } from 'vue' | |||
|
|
|||
| import { useEvent, useWindow } from './' | |||
There was a problem hiding this comment.
Prefer direct import by path to prevent circular dependecies...
|
|
||
| const cancelTouch = () => { | ||
| clearTouchTimeouts() | ||
| removeTouchCancelListeners() |
There was a problem hiding this comment.
useEvent must be used outside of onTouchStart function and there will no be needed to add removeTouchCancelListeners...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2142
Description
useTouchcomposable implementation;VaDropdown;useEventcomposable improvement;Types of changes