-
Notifications
You must be signed in to change notification settings - Fork 357
fix: docs related sliders overflow #3852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Stars22
commented
Sep 11, 2023
- fixes related slider overflow: when the top slider value(set to min) becomes greater then the max value of bottom sliders close VaSlider goes overflow #3819
@@ -1,12 +1,12 @@ | |||
<template> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, my bad. missed the second slider. fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so we fixed the docs example. We didn't fix the underlying issue.
Range should be operational even if min/max are swapped. It's reasonable to expect user would do something similar in app.
We could either fix it in this PR or move to another issue, but this has to be addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. I think it's right to have fix in this pr. I'll check what we can do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created a possible solution, I can't say how it's optimal as it was not a trivial task to begin with )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
story is kind of draft not intended for merge, maybe will be helpful to play around with sliders
238b2d6
to
8c2f3ab
Compare
8c2f3ab
to
bda138d
Compare
f4fff5a
to
2359969
Compare