Skip to content

Remove Popover default color #4329

Open
@jones1008

Description

@jones1008

Vuestic-ui version: 1.9.11

Description

The default of the prop color of the Popover component is currently "#1b1a1f" as stated here.

As you can see in the screenshot, the background-color: var(--va-popover-content-background-color) of .va-popover__content is overwritten by the inline style background-color: #1b1a1. The CSS variable --va-popover-content-background-color is defined as --va-background-primary as you can see here.
Optimally the default of the prop color should not overwrite this css rule of .va-popover__content.

One possible solution would be to set the default of the prop color to backgroundPrimary.
But maybe it would make more sense to not have a default at all and just get the background-color from the CSS rule of .va-popover__content, and only overwrite it with an inline style, if the color prop is set.

grafik

Reproduction

Playground Link

Metadata

Metadata

Assignees

No one assigned

    Labels

    BUGSomething isn't working

    Type

    No type

    Projects

    Status

    Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions