Type mismatch in use of bitSet

[dirk-zimoch]

The BitSet::set() method declared here

pvDataCPP/src/misc/pv/bitSet.h

Line 102 in b3a1077

BitSet& set(uint32 bitIndex);

takes a 32 bit argument but is usually called with PVField::getFieldOffset() as an argument which returns size_t.

pvDataCPP/src/pv/pvData.h

Line 181 in b3a1077

std::size_t getFieldOffset() const;

Would it be safe to change the BitSet::set() method (and everything else related in class BitSet) to have a size_t argument instead?

[mdavidsaver]

Would it be safe to change the BitSet::set() ... size_t

Yes, probably? Widening from uint32 to size_t should be a compatible change.

everything else related in class BitSet

This "everything" may turn out to be a large set considering how widely BitSet is used within the PVA modules, and external dependent modules.