fix(open): linux error spawning new obsidian process (#346)

* fix(open): use luv to spawn obsidian app

* refactor: use jobstart for backwards compatibility

* refactor(open): add error logging to jobstart

* chore(open): change log message for consistent formatting

* chore(open): include shell command when logging error

* chore(open): reduce diff

* chore(open): last cleanup

Author: benelan

lua/obsidian/commands/open.lua

@@ -1,7 +1,6 @@
 local util = require "obsidian.util"
 local log = require "obsidian.log"
 local RefTypes = require("obsidian.search").RefTypes
-local run_job = require("obsidian.async").run_job
 
 ---@param client obsidian.Client
 return function(client, data)
@@ -56,6 +55,8 @@ return function(client, data)
     uri = ("obsidian://open?vault=%s&file=%s"):format(encoded_vault, encoded_path)
   end
 
+  uri = vim.fn.shellescape(uri)
+
   ---@type string, string[]
   local cmd, args
   if this_os == util.OSType.Linux then
@@ -81,5 +82,14 @@ return function(client, data)
 
   assert(cmd)
   assert(args)
-  run_job(cmd, args)
+
+  local cmd_with_args = cmd .. " " .. table.concat(args, " ")
+  vim.fn.jobstart(cmd_with_args, {
+    detach = true,
+    on_exit = function(_, exit_code)
+      if exit_code ~= 0 then
+        log.err("open command failed with exit code '%s': %s", exit_code, cmd_with_args)
+      end
+    end,
+  })
 end