Merge pull request #1040 from equalizedigital/william/pro-178-links-with-role-of-tab-should-be-excluded-from-improper-link

Enhancement: Add a test case for links with role of tab that should pass

Author: pattonwebz

src/pageScanner/checks/link-has-valid-href-or-role.js

@@ -15,8 +15,13 @@ export default {
 		const href = node.getAttribute( 'href' );
 		const role = node.getAttribute( 'role' ) || '';
 
-		// Allow if it's a button role
-		if ( role.toLowerCase().split( /\s+/ ).includes( 'button' ) ) {
+		// Allow roles of button or tab
+		if (
+			role
+				.toLowerCase()
+				.split( /\s+/ )
+				.some( ( r ) => [ 'button', 'tab' ].includes( r ) )
+		) {
 			return true;
 		}
 

tests/jest/rules/linkImproper.test.js

@@ -115,6 +115,11 @@ describe( 'Link Improper Rule', () => {
 				element.setAttribute( 'aria-hidden', 'true' );
 			},
 		},
+		{
+			name: 'Passes with role="tab"',
+			html: '<a href="#" role="tab">Link with role of tab</a>',
+			shouldPass: true,
+		},
 	] )( '$name', async ( { html, shouldPass, setup } ) => {
 		document.body.innerHTML = html;