Merge pull request #1387 from equalizedigital/codex/find-and-fix-bugs-in-plugin

Fix admin toolbar pro link UTM content

Author: SteveJonesDev

includes/classes/class-admin-toolbar.php

@@ -110,7 +110,7 @@ private function get_default_menu_items(): array {
 		// Add Get Pro submenu item (only show if pro is not installed or license is not valid).
 		if ( ! defined( 'EDACP_VERSION' ) || ! EDAC_KEY_VALID ) {
 			$pro_link = function_exists( 'edac_generate_link_type' ) 
-				? edac_generate_link_type( [ 'utm-content' => 'admin-toolbar' ] )
+				? edac_generate_link_type( [ 'utm_content' => 'admin-toolbar' ] )
 				: 'https://equalizedigital.com/accessibility-checker/pricing/';
 
 			$menu_items[] = [

tests/phpunit/includes/classes/AdminToolbarTest.php

@@ -94,4 +94,31 @@ public function test_get_default_menu_items_returns_array() {
 		$this->assertNotEmpty( $items );
 		$this->assertArrayHasKey( 'id', $items[0] );
 	}
+
+	/**
+	 * Test pro menu link uses the expected UTM content parameter key.
+	 */
+	public function test_get_default_menu_items_pro_link_uses_utm_content() {
+		if ( ! function_exists( 'edac_generate_link_type' ) ) {
+			$this->markTestSkipped( 'edac_generate_link_type is not available in this test environment.' );
+		}
+
+		$reflection = new \ReflectionClass( Admin_Toolbar::class );
+		$method     = $reflection->getMethod( 'get_default_menu_items' );
+		$method->setAccessible( true );
+		$toolbar = new Admin_Toolbar();
+		$items   = $method->invoke( $toolbar );
+
+		$pro_item = null;
+		foreach ( $items as $item ) {
+			if ( 'accessibility-checker-pro' === $item['id'] ) {
+				$pro_item = $item;
+				break;
+			}
+		}
+
+		$this->assertNotNull( $pro_item );
+		$this->assertStringContainsString( 'utm_content=admin-toolbar', $pro_item['href'] );
+		$this->assertStringNotContainsString( 'utm-content=admin-toolbar', $pro_item['href'] );
+	}
 }