Revoke synced capabilities when their backing option is deleted

register() only hooked add_option/update_option, so deleting the
option (e.g. Pro's uninstall routine, gated behind the "delete data"
preference) left every role that had been granted the bundle stuck
with it indefinitely - the old array_intersect()-against-get_option()
check re-read the option live on every request, so this is a real
behavior change from before: deleting the option used to revoke
access instantly for everyone but admins, and now it wouldn't at all.
Hooking delete_option_{$option_name} to sync([]) closes that gap.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Author: pattonwebz

includes/classes/Capabilities/SyncCapability.php

@@ -113,6 +113,18 @@ function ( $old_value, $value ) {
 			10,
 			2
 		);
+		// Whatever deleted the option (typically an uninstall routine, gated
+		// behind the "delete data" preference) intends for the roles it
+		// granted to lose these capabilities too - without this, sync()
+		// would only ever run again on the next add_option/update_option,
+		// leaving the capabilities stuck on whichever roles had them at
+		// deletion time indefinitely.
+		add_action(
+			"delete_option_{$this->option_name}",
+			function () {
+				$this->sync( [] );
+			}
+		);
 
 		// init, not admin_init: admin_menu (where menu capability checks happen)
 		// and rest_api_init (where REST permission_callbacks are registered) both

tests/phpunit/includes/classes/Capabilities/SyncCapabilityTest.php

@@ -99,6 +99,30 @@ public function test_register_syncs_on_option_save() {
 		$this->assertTrue( wp_roles()->get_role( 'editor' )->has_cap( self::TEST_CAP ) );
 	}
 
+	/**
+	 * Deleting the option (e.g. an uninstall routine's opt-in data cleanup)
+	 * should revoke the capability from every role it was synced onto - the
+	 * option's own removal is the strongest possible signal that a stale
+	 * grant shouldn't be left behind, and there is no other hook left that
+	 * would ever catch this since add_option/update_option only fire again
+	 * on a future save.
+	 *
+	 * @return void
+	 */
+	public function test_deleting_option_revokes_capability_from_all_roles() {
+		$capability = new SyncCapability( self::TEST_CAP, self::TEST_OPTION );
+		$capability->register();
+
+		add_option( self::TEST_OPTION, [ 'editor', 'author' ] );
+		$this->assertTrue( wp_roles()->get_role( 'editor' )->has_cap( self::TEST_CAP ) );
+		$this->assertTrue( wp_roles()->get_role( 'author' )->has_cap( self::TEST_CAP ) );
+
+		delete_option( self::TEST_OPTION );
+
+		$this->assertFalse( wp_roles()->get_role( 'editor' )->has_cap( self::TEST_CAP ) );
+		$this->assertFalse( wp_roles()->get_role( 'author' )->has_cap( self::TEST_CAP ) );
+	}
+
 	/**
 	 * Manage_options users must always pass user_can(), regardless of
 	 * whether their role was synced.