Handle missing EDAC key flag

Author: SteveJonesDev

includes/classes/class-admin-toolbar.php

@@ -108,7 +108,7 @@ private function get_default_menu_items(): array {
 		];
 
 		// Add Get Pro submenu item (only show if pro is not installed or license is not valid).
-		if ( ! defined( 'EDACP_VERSION' ) || ! EDAC_KEY_VALID ) {
+		if ( ! defined( 'EDACP_VERSION' ) || ! defined( 'EDAC_KEY_VALID' ) || ! EDAC_KEY_VALID ) {
 			$pro_link = function_exists( 'edac_generate_link_type' ) 
 				? edac_generate_link_type( [ 'utm_content' => 'admin-toolbar' ] )
 				: 'https://equalizedigital.com/accessibility-checker/pricing/';

tests/phpunit/includes/classes/AdminToolbarTest.php

@@ -95,6 +95,36 @@ public function test_get_default_menu_items_returns_array() {
 		$this->assertArrayHasKey( 'id', $items[0] );
 	}
 
+	/**
+	 * Test get_default_menu_items() handles missing EDAC_KEY_VALID when pro is defined.
+	 *
+	 * @runInSeparateProcess
+	 */
+	public function test_get_default_menu_items_handles_missing_edac_key_valid_constant() {
+		if ( defined( 'EDAC_KEY_VALID' ) ) {
+			$this->markTestSkipped( 'EDAC_KEY_VALID is already defined in this test environment.' );
+		}
+		if ( ! defined( 'EDACP_VERSION' ) ) {
+			define( 'EDACP_VERSION', '1.0.0' );
+		}
+
+		$reflection = new \ReflectionClass( Admin_Toolbar::class );
+		$method     = $reflection->getMethod( 'get_default_menu_items' );
+		$method->setAccessible( true );
+		$toolbar = new Admin_Toolbar();
+		$items   = $method->invoke( $toolbar );
+
+		$pro_item = null;
+		foreach ( $items as $item ) {
+			if ( 'accessibility-checker-pro' === $item['id'] ) {
+				$pro_item = $item;
+				break;
+			}
+		}
+
+		$this->assertNotNull( $pro_item );
+	}
+
 	/**
 	 * Test pro menu link uses the expected UTM content parameter key.
 	 */