fix: make confirmed accessible first dismiss reason default

Co-authored-by: pattonwebz <3902039+pattonwebz@users.noreply.github.com>

Author: Copilot

admin/class-ignore-ui.php

@@ -27,6 +27,10 @@ class IgnoreUI {
 	 */
 	public static function get_reasons(): array {
 		return [
+			'accessible'     => [
+				'label'       => __( 'Confirmed accessible', 'accessibility-checker' ),
+				'description' => __( 'Reviewed and verified to meet accessibility requirements.', 'accessibility-checker' ),
+			],
 			'false_positive' => [
 				'label'       => __( 'False positive', 'accessibility-checker' ),
 				'description' => __( 'The scanner flagged this, but it does not apply to this content.', 'accessibility-checker' ),
@@ -35,10 +39,6 @@ public static function get_reasons(): array {
 				'label'       => __( 'Remediated', 'accessibility-checker' ),
 				'description' => __( 'The issue has been fixed, but the page has not been rescanned yet.', 'accessibility-checker' ),
 			],
-			'accessible'     => [
-				'label'       => __( 'Confirmed accessible', 'accessibility-checker' ),
-				'description' => __( 'Reviewed and verified to meet accessibility requirements.', 'accessibility-checker' ),
-			],
 		];
 	}
 

src/issueModal/components/DismissPanel.js

@@ -29,7 +29,7 @@ import { getDismissReasonOptions } from '../../sidebar/utils/dismissHelpers';
  */
 const DismissPanel = ( { issue, isOpen, onToggle, onIgnore, onCloseModal, forceGlobal = false, isPro = typeof window !== 'undefined' && window.edac_editor_app?.pro === '1' } ) => {
 	const [ comment, setComment ] = useState( issue?.ignre_comment ? decodeEntities( issue.ignre_comment ) : '' );
-	const [ dismissReason, setDismissReason ] = useState( issue?.ignre_reason || 'false_positive' );
+	const [ dismissReason, setDismissReason ] = useState( issue?.ignre_reason || 'accessible' );
 	const [ isSubmitting, setIsSubmitting ] = useState( false );
 	const [ error, setError ] = useState( null );
 	const [ successNotice, setSuccessNotice ] = useState( null );

tests/jest/issueModal/DismissPanel.test.js

@@ -50,6 +50,29 @@ jest.mock( '../../../src/issueModal/index', () => ( {
 } ) );
 
 describe( 'DismissPanel', () => {
+	test( 'defaults dismiss reason to confirmed accessible for new dismissals', async () => {
+		const { toggleIssueDismiss } = require( '../../../src/issueModal/api' );
+		const { container, unmount } = renderReact(
+			<DismissPanel
+				issue={ { id: 3, ignre: '0', ignre_global: 0 } }
+				isOpen={ true }
+				onToggle={ jest.fn() }
+				onIgnore={ jest.fn() }
+				onCloseModal={ jest.fn() }
+				isPro={ false }
+			/>,
+		);
+
+		await act( async () => {
+			container.querySelector( 'form' ).dispatchEvent(
+				new Event( 'submit', { bubbles: true, cancelable: true } ),
+			);
+		} );
+		expect( toggleIssueDismiss ).toHaveBeenCalledWith( 3, true, 'accessible', '', false );
+
+		unmount();
+	} );
+
 	test( 'hides global dismiss controls for free users', () => {
 		window.edac_editor_app.pro = '0';
 

tests/jest/setupTests.js

@@ -16,9 +16,9 @@ beforeEach( () => {
 		highlightNonce: 'test-highlight-nonce',
 		canManageSettings: true,
 		dismissReasons: {
+			accessible: { label: 'Confirmed accessible', description: 'Reviewed and verified to meet accessibility requirements.' },
 			false_positive: { label: 'False Positive', description: 'This issue does not apply to this content.' },
 			remediated: { label: 'Remediated', description: 'This issue has been fixed.' },
-			accessible: { label: 'Accessible', description: 'This content is accessible by other means.' },
 		},
 	};
 	window.edac_editor_app = {

tests/jest/sharedComponents/dismissHelpers.test.js

@@ -7,6 +7,10 @@
  */
 
 const FIXTURE_REASONS = {
+	accessible: {
+		label: 'Confirmed accessible',
+		description: 'Reviewed and verified to meet accessibility requirements.',
+	},
 	false_positive: {
 		label: 'False positive',
 		description: 'This issue does not apply to this content.',
@@ -15,10 +19,6 @@ const FIXTURE_REASONS = {
 		label: 'Remediated',
 		description: 'This issue has been fixed.',
 	},
-	accessible: {
-		label: 'Accessible',
-		description: 'This content is accessible by other means.',
-	},
 };
 
 /**
@@ -83,9 +83,9 @@ describe( 'dismissHelpers', () => {
 			const options = getDismissReasonOptions();
 			const values = options.map( ( o ) => o.value );
 
+			expect( values[ 0 ] ).toBe( 'accessible' );
 			expect( values ).toContain( 'false_positive' );
 			expect( values ).toContain( 'remediated' );
-			expect( values ).toContain( 'accessible' );
 		} );
 
 		test( 'returns empty array when no dismiss reasons exist', () => {
@@ -99,7 +99,7 @@ describe( 'dismissHelpers', () => {
 			const { getDismissReasonLabel } = loadHelpers( FIXTURE_REASONS );
 			expect( getDismissReasonLabel( 'false_positive' ) ).toBe( 'False positive' );
 			expect( getDismissReasonLabel( 'remediated' ) ).toBe( 'Remediated' );
-			expect( getDismissReasonLabel( 'accessible' ) ).toBe( 'Accessible' );
+			expect( getDismissReasonLabel( 'accessible' ) ).toBe( 'Confirmed accessible' );
 		} );
 
 		test( 'returns empty string for an unknown reason value', () => {
@@ -116,6 +116,7 @@ describe( 'dismissHelpers', () => {
 	describe( 'getDismissReasonDescription', () => {
 		test( 'returns the description for a known reason value', () => {
 			const { getDismissReasonDescription } = loadHelpers( FIXTURE_REASONS );
+			expect( getDismissReasonDescription( 'accessible' ) ).toBe( 'Reviewed and verified to meet accessibility requirements.' );
 			expect( getDismissReasonDescription( 'false_positive' ) ).toBe( 'This issue does not apply to this content.' );
 			expect( getDismissReasonDescription( 'remediated' ) ).toBe( 'This issue has been fixed.' );
 		} );
@@ -131,4 +132,3 @@ describe( 'dismissHelpers', () => {
 		} );
 	} );
 } );
-