Fix three code review issues in workflow caching

node_modules cache + npm ci: npm ci deletes node_modules before
reinstalling, so restoring the cache and then running npm ci was a
no-op — the restored directory was thrown away immediately. Fix by
adding id: cache-node-modules to each cache step and guarding the
install with if: cache-hit != 'true'. On an exact key match the
install is skipped entirely; on a partial or missing match npm ci
runs normally and saves the result.

Affects: jest-tests.yml, lint-js.yml, make-pot.yml,
build-plugin-with-ref.yml (replaced the manual [ -d node_modules ]
shell check with the proper cache-hit output).

npm config set ignore-scripts true: this flag persists for the
remainder of the job, disabling lifecycle scripts in later steps
(e.g. Cypress setup). Replaced with the per-command --ignore-scripts
flag on npm ci in jest-tests.yml and copilot-setup-steps.yml.

WP test library cached under 'latest' key: install-wp-tests.sh
returns immediately when /tmp/wordpress already exists, so a cached
'latest' run can keep serving an older WordPress release after
upstream ships a new one. Added if: matrix.wp_version != 'latest'
to skip caching for the three matrix jobs that use the moving target;
the pinned 6.2 job continues to benefit from the cache.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: pattonwebz

.github/workflows/build-plugin-with-ref.yml

@@ -81,6 +81,7 @@ jobs:
           cache-dependency-path: package-lock.json
 
       - name: Cache node_modules
+        id: cache-node-modules
         uses: actions/cache@v4
         with:
           path: node_modules
@@ -108,16 +109,8 @@ jobs:
           if [ -f composer.json ]; then composer install --no-dev --prefer-dist --prefer-offline --no-progress --no-interaction; else echo "No composer.json"; fi
 
       - name: Install npm dependencies
-        run: |
-          if [ -f package.json ]; then
-            if [ -d node_modules ]; then
-              echo "node_modules cache hit, skipping install"
-            else
-              npm ci --prefer-offline --no-audit
-            fi
-          else
-            echo "No package.json"
-          fi
+        if: steps.cache-node-modules.outputs.cache-hit != 'true' && hashFiles('package.json') != ''
+        run: npm ci --prefer-offline --no-audit
 
       - name: Extract plugin version and commit hash
         id: version

.github/workflows/copilot-setup-steps.yml

@@ -64,10 +64,7 @@ jobs:
             ${{ runner.os }}-docker-
 
       - name: Install npm dependencies
-        run: |
-          # Skip postinstall scripts to avoid Cypress download issues in CI
-          npm config set ignore-scripts true
-          npm ci --prefer-offline --no-audit
+        run: npm ci --ignore-scripts --prefer-offline --no-audit
 
       - name: Install Composer dependencies
         run: |

.github/workflows/jest-tests.yml

@@ -27,6 +27,7 @@ jobs:
             ${{ runner.os }}-node-
 
       - name: Cache node_modules
+        id: cache-node-modules
         uses: actions/cache@v4
         with:
           path: node_modules
@@ -35,9 +36,8 @@ jobs:
             ${{ runner.os }}-node_modules-
 
       - name: Install dependencies (skipping postinstall)
-        run: |
-          npm config set ignore-scripts true
-          npm ci --prefer-offline --no-audit
+        if: steps.cache-node-modules.outputs.cache-hit != 'true'
+        run: npm ci --prefer-offline --no-audit --ignore-scripts
 
       - name: Run Jest tests
         run: npm run test:jest

.github/workflows/lint-js.yml

@@ -29,6 +29,7 @@ jobs:
         uses: actions/checkout@v3
 
       - name: Cache Node.js modules
+        id: cache-node-modules
         uses: actions/cache@v4
         with:
           path: node_modules
@@ -37,6 +38,7 @@ jobs:
             ${{ runner.os }}-node_modules-
       # The lint stage doesn't run the unit tests or use code style, so no need for PHPUnit, WPCS or phpcompatibility.
       - name: 'Install NPM packages'
+        if: steps.cache-node-modules.outputs.cache-hit != 'true'
         run: npm ci --prefer-offline --no-audit --ignore-scripts
 
       - name: Get only files changed in this PR

.github/workflows/make-pot.yml

@@ -45,6 +45,7 @@ jobs:
           node-version: '20'
 
       - name: Cache Node.js modules
+        id: cache-node-modules
         uses: actions/cache@v4
         with:
           path: node_modules
@@ -53,6 +54,7 @@ jobs:
             ${{ runner.os }}-node_modules-
 
       - name: Install dependencies
+        if: steps.cache-node-modules.outputs.cache-hit != 'true'
         run: npm ci --prefer-offline --no-audit --ignore-scripts
 
       - name: Build plugin (dotorg dist)

.github/workflows/phpunit.yml

@@ -94,6 +94,7 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Cache WordPress test library
+        if: matrix.wp_version != 'latest'
         uses: actions/cache@v4
         with:
           path: |