Make wp-a11y an unconditional admin dependency

Author: benitoalba

admin/class-enqueue-admin.php

@@ -83,12 +83,7 @@ public static function maybe_enqueue_admin_and_editor_app_scripts() {
 			// let extensions supply the correct ID (e.g. a Pro virtual-page ID).
 			$post_id = apply_filters( 'edac_filter_admin_post_id', $post_id );
 
-			$admin_script_dependencies = [ 'jquery' ];
-			if ( 'accessibility_checker_settings' === $page ) {
-				$admin_script_dependencies[] = 'wp-a11y';
-			}
-
-			wp_enqueue_script( 'edac', plugin_dir_url( EDAC_PLUGIN_FILE ) . 'build/admin.bundle.js', $admin_script_dependencies, EDAC_VERSION, false );
+			wp_enqueue_script( 'edac', plugin_dir_url( EDAC_PLUGIN_FILE ) . 'build/admin.bundle.js', [ 'jquery', 'wp-a11y' ], EDAC_VERSION, false );
 			wp_set_script_translations( 'edac', 'accessibility-checker', plugin_dir_path( EDAC_PLUGIN_FILE ) . 'languages' );
 			wp_localize_script(
 				'edac',

tests/phpunit/Admin/EnqueueAdminTest.php

@@ -90,7 +90,7 @@ public function testEnqueueBaseScriptInAdminNonEditorPage() {
 
 		$this->assertTrue( wp_script_is( 'edac', 'enqueued' ) );
 		$this->assertFalse( wp_script_is( 'edac-editor-app', 'enqueued' ) );
-		$this->assertNotContains( 'wp-a11y', $wp_scripts->registered['edac']->deps );
+		$this->assertContains( 'wp-a11y', $wp_scripts->registered['edac']->deps );
 
 		$localized_data = $wp_scripts->get_data( 'edac', 'data' );
 		$this->assertIsString( $localized_data );