Skip to content

Commit dd032c4

Browse files
Merge pull request #1205 from equalizedigital/steve/no-issue/youtube-video-keyword
updated: video selector to exclude script tags and add test case for YouTube API
2 parents ac718c5 + 9ee76bb commit dd032c4

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

src/pageScanner/rules/video-present.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
export default {
88
id: 'video_present',
9-
selector: 'video, iframe, object, source, [src], [role]',
9+
selector: 'video, iframe, object, source, [src]:not(script), [role]',
1010
excludeHidden: false,
1111
tags: [
1212
'wcag2a',

tests/jest/rules/videoElementPresent.test.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,11 @@ describe( 'video_present rule', () => {
135135
html: '<audio controls><source src="sound.mp3" type="audio/mpeg"></audio>',
136136
shouldPass: true,
137137
},
138+
{
139+
name: 'does not detect YouTube API script tag',
140+
html: '<script type="text/javascript" src="https://www.youtube.com/iframe_api?ver=1.2.6" id="youtube-scripts-js"></script>',
141+
shouldPass: true,
142+
},
138143
];
139144

140145
testCases.forEach( ( testCase ) => {

0 commit comments

Comments
 (0)