Make edac_get_origin_url_for_virtual_page accept string as first param

This makes the pattern of sending string and returning string more clear, the id is still passed through as well to get the virtual url for it

If no virtual url is found the original string is passed back, the original string is usually a permalink

[PRO-169]

Author: pattonwebz

admin/class-ajax.php

@@ -493,6 +493,7 @@ function ( $a, $b ) {
 
 							$post_view_link = apply_filters(
 								'edac_get_origin_url_for_virtual_page',
+								get_the_permalink( $postid ),
 								$postid
 							);
 
@@ -501,7 +502,7 @@ function ( $a, $b ) {
 									'edac'       => $id,
 									'edac_nonce' => wp_create_nonce( 'edac_highlight' ),
 								],
-								is_string( $post_view_link ) ? $post_view_link : get_the_permalink( $postid )
+								$post_view_link
 							);
 
 							// Translators: %d is the issue ID.

admin/class-enqueue-admin.php

@@ -114,14 +114,15 @@ public static function maybe_enqueue_admin_and_editor_app_scripts() {
 				} else {
 					$post_view_link = apply_filters(
 						'edac_get_origin_url_for_virtual_page',
+						get_preview_post_link( $post_id ),
 						$post_id
 					);
 
 					$scan_url = add_query_arg(
 						[
 							'edac_pageScanner' => 1,
 						],
-						is_string( $post_view_link ) ? $post_view_link : get_preview_post_link( $post_id )
+						$post_view_link
 					);
 				}
 

includes/helper-functions.php

@@ -774,6 +774,7 @@ function edac_generate_landmark_link( $landmark, $landmark_selector, $post_id, $
 	if ( ! empty( $landmark_selector ) ) {
 		$link = apply_filters(
 			'edac_get_origin_url_for_virtual_page',
+			get_the_permalink( $post_id ),
 			$post_id
 		);
 
@@ -782,7 +783,7 @@ function edac_generate_landmark_link( $landmark, $landmark_selector, $post_id, $
 				'edac_landmark' => base64_encode( $landmark_selector ),
 				'edac_nonce'    => wp_create_nonce( 'edac_highlight' ),
 			],
-			is_string( $link ) ? $link : get_the_permalink( $post_id )
+			$link
 		);
 
 		// translators: %s is the landmark type (e.g., "Header", "Navigation", "Main").