Skip to content

Commit 4c1602d

Browse files
Explicitly count done simulations
Previously processing simulations would be considered done as well
1 parent b35270b commit 4c1602d

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

frontend/src/components/GridSimulation/GridResults.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,8 @@ const GridResults: React.FC<GridResultsProps> = ({ result }) => {
145145
const sections = buildModelSections(inputModels, models);
146146

147147
const erroredSimulations = simulations.filter((sim) => sim.status === "error");
148-
const pendingSimulations = simulations.filter((sim) => sim.status === "pending");
148+
const doneSimulations = simulations.filter((sim) => sim.status === "done");
149+
const allFinished = doneSimulations.length + erroredSimulations.length === simulations.length;
149150

150151
const xAxisSubstance = axes[0]?.substance ?? "Unknown";
151152
const modelLabel = inputModels.map((model) => model.modelId).join(" → ") || "Unknown model";
@@ -165,13 +166,12 @@ const GridResults: React.FC<GridResultsProps> = ({ result }) => {
165166
<strong>{modelLabel}</strong>.
166167
</Typography>
167168

168-
{pendingSimulations.length > 0 && (
169+
{!allFinished && (
169170
<Banner style={{ marginBottom: "1rem" }}>
170171
<Banner.Icon variant="info"></Banner.Icon>
171172
<Banner.Message>
172-
Showing partial results. {simulations.length - pendingSimulations.length} of{" "}
173-
{simulations.length} runs have finished; the remaining {pendingSimulations.length} appear as
174-
they complete.
173+
Showing partial results. {doneSimulations.length} of {simulations.length} runs have finished;
174+
the rest appear as they complete.
175175
</Banner.Message>
176176
</Banner>
177177
)}

0 commit comments

Comments
 (0)